Coder Social home page Coder Social logo

Comments (4)

dudil avatar dudil commented on May 18, 2024 2

@tiangolo - quick look for the root cause I found this is an issue with the GitHub action of uvicorn-gunicorn-docker.

There is an open PR for fixing it but I'm not sure how much updated it is or still relevant.

However, seems like @tedvim who create the PR made a huge step forward and build a full registry of python stack images which are already multi-arch and updated https://github.com/multi-py
Switching the backend base image to be based on https://github.com/multi-py/python-gunicorn + fastapi, could push your amazing project forward and remove the need for you to maintain also the docker images.
I'll be more than happy to assist and make the fix if you think the same. 💐

from full-stack-fastapi-postgresql.

dudil avatar dudil commented on May 18, 2024

Hi @renja-g, a quick fix would be to add the following line into the docker-compose.yml backend section:

...
...
build:
      context: ./backend
      args:
        INSTALL_DEV: ${INSTALL_DEV-false}
    
    platform: linux/amd64 # Add this line for M1 Macs
...
...

@tiangolo , I will issue a PR for quickly fix that if you don't mind.

I'm not sure why the base image you are building from tiangolo/uvicorn-gunicorn is marked as supporting only amd64,
The base image of that one is python:3.10 which also supports arm64.

from full-stack-fastapi-postgresql.

tiangolo avatar tiangolo commented on May 18, 2024

Thanks @dudil! 🙇 Thanks for the help and the fix!

@renja-g this was handled in #710 🤓

from full-stack-fastapi-postgresql.

billzhong avatar billzhong commented on May 18, 2024

Hi @dudil , seems like multi-arch support is added: tiangolo/uvicorn-gunicorn-fastapi-docker#273 . So your patch is not longer need. It would be nice to remove it to improve the performance at Apple Silicon.

from full-stack-fastapi-postgresql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.