tiabc / doubleratchet Goto Github PK

Hi!
Thanks for the library, I am integrating https://github.com/status-im/doubleratchet with the status application, I have a few questions and I was hoping you could confirm some doubts.

The application is a mobile app, so it will need persistence on disk. I have implemented keysstorage, but seems like to get it working correctly we need also to persist and reload state when a new struct is created, otherwise key re-use happens.

Essentially when the process is restarted, we have to create a new session, but we don't want N and PN to be set back to 0, as we have already performed some steps in the ratchet.

I had a look at the signal implementation and seems like they are also persisting session state https://github.com/signalapp/libsignal-protocol-java/blob/master/java/src/main/java/org/whispersystems/libsignal/state/SessionRecord.java.

Could you confirm if I am on the right track before I start coding away or I am missing something?

Thank you!

Hi,

I have a few questions:

1. I would like to return errors from the key store since I currently have to drop the errors in order to satisfy the interface. Would you accept such an PR if I change the interface?

2. Are message keys deleted at some point? I see that there is a DeletePk function however, it's only used to delete skipped keys as far as I can see. Since we have to safe all messages encrypted - we can just persist the messages keys and will be able to decrypt all messages from those keys at any point in time (or am I wrong)?

cheers,
Florian

P.s. thanks for this great repo