tiaanv / esphome-components Goto Github PK

Hi,
It would be very nice to not erase display content on initialization. This would work great with ESPHome in deep sleep, then display would only be redrawn after wakeup, network initialization and data received from Home Assistant.
With current driver, it takes approx. 10 seconds with a blank screen before startup is completed and data is visible again.
Besides that everything works great - thanks for the good work.

with a recent checkout of esphome, this produces an compile time error:

src/main.cpp:34:1: error: 't547' does not name a type
 t547::T547 *t5_display;
 ^

It seems that without an empty custom_components/t547/__init__.py, esphome won't add the include headers to the main.cpp. Touching that file is enough to make it work again: esphome/feature-requests#1109 (comment)

I'm not well-versed enough in esphome to know if there is something else that should be in that file, only that it worked for me...

ESPHome 2023.8.3

Traceback (most recent call last):
  File "/usr/local/bin/esphome", line 33, in <module>
    sys.exit(load_entry_point('esphome', 'console_scripts', 'esphome')())
  File "/esphome/esphome/__main__.py", line 1023, in main
    return run_esphome(sys.argv)
  File "/esphome/esphome/__main__.py", line 1010, in run_esphome
    rc = POST_CONFIG_ACTIONS[args.command](args, config)
  File "/esphome/esphome/__main__.py", line 441, in command_run
    exit_code = write_cpp(config)
  File "/esphome/esphome/__main__.py", line 185, in write_cpp
    generate_cpp_contents(config)
  File "/esphome/esphome/__main__.py", line 197, in generate_cpp_contents
    CORE.flush_tasks()
  File "/esphome/esphome/core/__init__.py", line 626, in flush_tasks
    self.event_loop.flush_tasks()
  File "/esphome/esphome/coroutine.py", line 246, in flush_tasks
    next(task.iterator)
  File "/esphome/esphome/__main__.py", line 177, in wrapped
    await coro(conf)
  File "/config/esphome/.esphome/external_components/15342b1e/components/t547/display.py", line 43, in to_code
    config[CONF_LAMBDA], [(display.DisplayBufferRef, "it")], return_type=cg.void
AttributeError: module 'esphome.components.display' has no attribute 'DisplayBufferRef'

Hello!

Thank you for your work on the the component for the display functionality on the Lilygo T5. I am currently making use of it in place of the same component from vbaksa which I was using in the past, however now am unable to as it wont compile due to what is most likely the same issue you had to resolve within your component.

My question to you is, do you have any idea why I am unable to use the native ESPHome Lilygo T5 4.7” Touchscreen component using your display component?

It would appear that the touchscreen component has been updated to require a "display" variable, which fails when using your display component :(

I thank you in advanced for your assistance!

Hey,
I noticed you didn't specify the license for this repository.
Would you be willing to use the same license as ESPHome does (MIT for Python / GPLv3 for C(++)?

To provide some context: I'm looking into making ESPHome work with the ESP32-S3 based version of T5-4.7 by taking the same approach as you have (i.e. implementing esphome's display APIs using calls into lilygo's EPD library). I'm contemplating if I should make it a fork/variant of your component or a separate thing, inspired by your excellent work.