Coder Social home page Coder Social logo

Use key instead of url about aws HOT 5 CLOSED

thumbor-community avatar thumbor-community commented on August 17, 2024
Use key instead of url

from aws.

Comments (5)

Bladrak avatar Bladrak commented on August 17, 2024

@pgr0ss seems you're right, could you submit a PR with the edit? And add some test coverage on this?

from aws.

pgr0ss avatar pgr0ss commented on August 17, 2024

I tried to add a test, but I'm having trouble. I can't get my new test to fail, even when I explicitly raise in the check. Can you help me figure out what I'm doing wrong? I haven't written python in a while, and I've never used vows.

pgr0ss@37a0b51#diff-77c2dd61924c56b9f0a85ad0ba044663R66

from aws.

Bladrak avatar Bladrak commented on August 17, 2024

@pgr0ss I commented directly on your diff :)

from aws.

Bladrak avatar Bladrak commented on August 17, 2024

@pgr0ss I noticed some issues in the code while looking into the tests, I've fixed those issues in the commit 2ae3727
There's also an update on the tests that were always passing due to async, they are now more consistent.

Thanks for reporting this and working on it! I've released 1.3.2 on pypi with this fix. If you could close the issue once you checked it's resolved.

from aws.

pgr0ss avatar pgr0ss commented on August 17, 2024

I just checked and it's working for me. Thanks!

from aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.