Comments (5)
@pgr0ss seems you're right, could you submit a PR with the edit? And add some test coverage on this?
from aws.
I tried to add a test, but I'm having trouble. I can't get my new test to fail, even when I explicitly raise in the check. Can you help me figure out what I'm doing wrong? I haven't written python in a while, and I've never used vows.
pgr0ss@37a0b51#diff-77c2dd61924c56b9f0a85ad0ba044663R66
from aws.
@pgr0ss I commented directly on your diff :)
from aws.
@pgr0ss I noticed some issues in the code while looking into the tests, I've fixed those issues in the commit 2ae3727
There's also an update on the tests that were always passing due to async, they are now more consistent.
Thanks for reporting this and working on it! I've released 1.3.2 on pypi with this fix. If you could close the issue once you checked it's resolved.
from aws.
I just checked and it's working for me. Thanks!
from aws.
Related Issues (20)
- Remove dependency to tornado_botocore
- Cannot DELETE when TC_AWS_RANDOMIZE_KEYS = True HOT 2
- Credentials not found when using IAM role for EC2 instance HOT 1
- Cannot load files from s3 bucket HOT 1
- S3 key not found at HOT 2
- Plan to support customized result storage path?
- thumbor s3 upload
- Multiple TC_AWS_LOADER_BUCKET HOT 2
- Delete file from S3 fails because of missing normalization HOT 6
- Cannot load files from S3 bucket larger than 100mb HOT 1
- Support thumbor v7.x. HOT 25
- Getting "No security key was found" HOT 2
- Migrating from old version: 404 on old images HOT 2
- Feature request: modify S3 result storage path to make for easier deletion HOT 2
- Need Help with Configuration HOT 1
- Images are not complete when getting it from server HOT 1
- Help to upgrade this to 7.0.0 HOT 1
- Thumbor watermark Filters shows multiple image(2 watermark image)
- Use a more up-to-date aiobotocore to allow assumeRole iam credentials HOT 7
- Feature Request - Multiple S3 bucket support for image loader piece HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws.