Comments (25)
Is there an ETA for the 7.x update?
from aws.
You can now test a pre-release of the compatibility with Thumbor 7 & python 3 here: https://pypi.org/project/tc-aws/7.0b0/
and https://github.com/thumbor-community/aws/releases. Huge thanks to @amanagr and @peterrus for their contribution!
from aws.
Thanks @jimas14 as well! Sorry I missed you :)
@peterrus I'd wait a few weeks to see if there are feedbacks from users before merging this to master and releasing a stable version. Ideally we should fix the warnings indeed.
from aws.
see #142
from aws.
this is blocking us from testing thumbor 7.x as well.
from aws.
There's a PR on thumbor (thumbor/thumbor#1342) that will allow legacy extensions to be used. Can someone help test thumbor with S3 using the new compatibility layer?
from aws.
I just tried testing the compatibility layer, but running into the following problem:
Would it be possible to publish a prerelease version that allows thumbor 7?
from aws.
I got thumbor 7 and tc_aws installed at the same time via pip install --no-deps tc_aws==6.2.15
and specifying the tc_aws
deps manually. Now I am running into compatibility issues with Python 3:
thumbor_1 | File "/usr/local/lib/python3.10/site-packages/tc_aws/loaders/__init__.py", line 9, in <module>
thumbor_1 | import urllib2
thumbor_1 | ModuleNotFoundError: No module named 'urllib2'
So there is at least work to do in first porting the package to Python 3, before the compatibility layer can be tested.
from aws.
Nevermind, looks like compat layer is not even needed with this PR #147
from aws.
And don't forget @jimas14! (:
from aws.
@Bladrak As you are probably more familiar with the project and it's history than I am: What would you consider to be the way forward to get this to be considered stable?
One thing I have noticed myself is that, while all unit test pass, we still have a ton of warnings, a portion of them related to deprecations: Test log of a recent build
By the way I am testing this pre release (7.0b0
) out myself and I can report that all seems to working fine so far!
from aws.
What's needed before a release can be made with the Thumbor 7 related changes?
from aws.
@Tenzer there's an alpha release available. We'll probably release a stable version in the coming weeks if no issues arise.
from aws.
Ah, I had missed that. Thanks, I'll try it out soon.
from aws.
Hi, have been running this in production for a few weeks now without any issues. Processing hundredths of requests per week on about 5 instances combined. Just created this account to provide some feedback (:
from aws.
Awesome fedback @charcoal3r!!! Thank you for that!
from aws.
Have issues arised since April? Or is the alpha stable enough to be released "for real"?
from aws.
We have many companies already running Thumbor 7 for real for a while now :) Go for it! Let us know how it goes.
from aws.
Regarding thumbor-community/aws I'll let the committers talk about it.
from aws.
After posting, I discovered https://github.com/thumbor/thumbor-aws, which is probably the correct answer here.
from aws.
Forgot about that, I'll release a stable release this week.
Nice seeing you here @aaugustin by the way ;-)
from aws.
@Bladrak That'd be nice!
By the way, do we now have two thumbor plugins that provide AWS functionality? Do we want that?
from aws.
@peterrus I wasn't aware that https://github.com/thumbor/thumbor-aws existed (I'm mostly maintaining this repo when I have some time), maybe this one is no longer needed. @heynemann maybe you can give a bit more insight? What are the main differences? Should we deprecate this repo in favor of the one on Thumbor org?
from aws.
TBH @Bladrak I created the other one just as a means to move adoption of 7.0.0 forward. There's not much different between them. Probably mine has bugs that this one doesn't :)
from aws.
Version 7.0.2 has been released, and is stable. I'm closing this with this release, thanks to everyone who contributed on this!
@heynemann let me know if you want to rationalise this, I'm not sure 2 repos make sense. I'm happy to help, whether in deprecating this repo, or moving it to the Thumbor org.
from aws.
Related Issues (20)
- Remove dependency to tornado_botocore
- Cannot DELETE when TC_AWS_RANDOMIZE_KEYS = True HOT 2
- Credentials not found when using IAM role for EC2 instance HOT 1
- Cannot load files from s3 bucket HOT 1
- S3 key not found at HOT 2
- Plan to support customized result storage path?
- thumbor s3 upload
- Multiple TC_AWS_LOADER_BUCKET HOT 2
- Delete file from S3 fails because of missing normalization HOT 6
- Cannot load files from S3 bucket larger than 100mb HOT 1
- Getting "No security key was found" HOT 2
- Migrating from old version: 404 on old images HOT 2
- Feature request: modify S3 result storage path to make for easier deletion HOT 2
- Need Help with Configuration HOT 1
- Images are not complete when getting it from server HOT 1
- Help to upgrade this to 7.0.0 HOT 1
- Thumbor watermark Filters shows multiple image(2 watermark image)
- Use a more up-to-date aiobotocore to allow assumeRole iam credentials HOT 7
- Feature Request - Multiple S3 bucket support for image loader piece HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws.