thujohn / share-l4 Goto Github PK

Can you use a wild card like lluminate/support: >=4.0.*
I can't add it to my laravel app because I'm on 4.0.*dev.

Thanks

Wonderful job by the way.

I think some of your other packages have this limitations as well.

Hi,

I took the liberty and add the function to share by email.

public function email(){
        return 'mailto:?subject=Site: ' . $this->text . '&body=Check out this site ' . $this->link;
}

Easy line but with this it looks cleaner on the view.

Not really an issue, but i personally think its cleaner to return objects in my views rather than arrays.

Add (object) to Share.php, Line 29:

return (object)$return;

Now i can use

$sharelink = Share::load(URL::to('someurlhere'), $something->title)->services('facebook', 'twitter');
$sharelink->facebook;
$sharelink->twitter;
...

Personal preference but imo looks cleaner in your view!

In order to get pinterest to actually show an image, I had to add media= to the share url. Not really an issue, but you might want to include it in the next update.

I have og:image set also, which facebook and reddit seem to support.

Hi,
Please incorporate the title, description and thumb image support.

Thanks,
Vikash

Is there any plans to support Laravel 5?