threez / file-queue Goto Github PK

Hello,

Problematic code is:

      that.watcher = that.fs.watch(that.dirPaths[NEW], {}, function(err, messages) {
        that.emit('new', [messages]);
      });

This code doesn't work for NFS3.

http://docs.libuv.org/en/v1.x/fs_event.html

    UV_FS_EVENT_WATCH_ENTRY = 1,
    /*
    * By default uv_fs_event will try to use a kernel interface such as inotify
    * or kqueue to detect events. This may not work on remote file systems such
    * as NFS mounts. This flag makes fs_event fall back to calling stat() on a
    * regular interval.
    * This flag is currently not implemented yet on any backend.
    */

Please, add polling: say for each 30-60 seconds fs.readdir -> if files are present emit 'new' event.

Hello,

how do you think is it possible to optimize code:

Maildir.prototype.listNew = function(callback) {
  this.fs.readdir(this.dirPaths[NEW], callback);
};

the point is for each pop operation it reads all content of the directory.

pop()->readdir()
pop()->readdir()
pop()->readdir()

In the sequence code

If the queue has size 1^e6 messages it .....

How about to optimize this place?
For example

• add memoize
  or
• consume result from listNew() until it has elements?
  Thank you.

Hi,

I implemented a simple example using the file-queue. I don't understand how I should process the queue. When I run "pop" it will just take one message from the queue and processes it.

So I understand that I need to take care of the queue itself, meaning that I need to check the length constantly and run pop by my own logic. It's not like pop is called whenever there is a new file in the queue, right?

Thanks for clarifying.

I'm trying to understand why/how this is "lock free" - what's the exact mechanism that makes it "lock free"?

thanks!

I had to modify the length function in order to get it to return correct values the way I am using it.

fs.stat ==> ulink was always reporting 2.

// Finds the length of the queue (list of files in new)
Maildir.prototype.length = function(callback) {
fs.readdir(this.dirPaths[NEW]+'/', function(err, files) {
if (err) { callback(err); }
else { callback(null, files.length); }
});
};

It seems that they are not created automatically, nevertheless the program doesn't crash