Coder Social home page Coder Social logo

Comments (6)

thomseddon avatar thomseddon commented on May 20, 2024

Thank you for the bug report! I tried to do as much testing as I could in #26 but inevitably some bugs may slip through, the goal of v2 was to be fully backwards compatible so I'll look to push a fix ASAP.

I've just added some extra tests in 72fc88a and everything seems to work as expected.

Please could you provide an example config and let me know the behavior before/after, I'll look into it right away!

from traefik-forward-auth.

tardfree avatar tardfree commented on May 20, 2024

No problem.

The config I was using which I saw the bug on had the following environment variables set (viewed from docker inspect, this is all of them except PATH, names changed too)

"DOMAIN=mydomainname.net,anothername.com,athirdname.com",
"AUTH_HOST=login.mydomainname.net",
"COOKIE_DOMAINS=services.mydomainname.net",
"SECRET=secure string here",
"COOKIE_SECURE=false",
"CLIENT_ID=clientidhere",
"CLIENT_SECRET=secrethere",

If it helps, the domain I was trying to authenticate with was the middle one of the 3.
To work around the issue I've redeployed with a single domain in the list (until I'm back in my home country) and this is working again for me (for that single domain though).

from traefik-forward-auth.

tardfree avatar tardfree commented on May 20, 2024

Oops didn't answer the rest of your questions.
Before behaviour was users in the middle domain were able to authenticate as expected and get redirected to the intended page.
After the update, I received the "Not authorized" string in the browser, and the log message in the first post.
I'm not sure if any of my users in the other domains (first and third) have ever logged in, so that might not have been working.

from traefik-forward-auth.

thomseddon avatar thomseddon commented on May 20, 2024

Brilliant, I think I found the bug, I had incorrectly thought the v0 config option was called domains, however I can now see it was called domain!

I have fixed CSV support for domain and added tests for both the flag and the env var. I've also removed the domains config as this was never needed!

from traefik-forward-auth.

thomseddon avatar thomseddon commented on May 20, 2024

*I've pushed the fix in 3e92400

Thank you for your bug report and sorry for causing you an issue whilst you were away!

from traefik-forward-auth.

tardfree avatar tardfree commented on May 20, 2024

Thank you for the very quick fix and this simple tool. :)

from traefik-forward-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.