Problems with GItea OAuth about opengist

[thomiceli]

Thanks for the feedback, i will fix the first item.
For the second item, i would rather have an option in the admin panel to disable logins/signups with login and password.

Thoughts ?

[Shuenhoy]

Thanks for the feedback, i will fix the first item. For the second item, i would rather have an option in the admin panel to disable logins/signups with login and password.

Thoughts ?

Thanks for your reply!
I think it's ok to have the option in the admin panel.

[josefandersson]

i would rather have an option in the admin panel to disable logins/signups with login and password

Hey @thomiceli what's the thought process behind whether an option should go in the admin panel or the config? My initial thought was that no option should go in the Admin panel since it's unnecessary and just arbitrarily spreads settings up into two kinds. Instead I feel that the Admin panel should solely be for user/data administration, that cannot reasonably be done via config file.

[thomiceli]

i would rather have an option in the admin panel to disable logins/signups with login and password

Hey @thomiceli what's the thought process behind whether an option should go in the admin panel or the config? My initial thought was that no option should go in the Admin panel since it's unnecessary and just arbitrarily spreads settings up into two kinds. Instead I feel that the Admin panel should solely be for user/data administration, that cannot reasonably be done via config file.

I had the same reasoning, then it turned out it would be painful to have some of the options in the config file (see #5 and #8). So i like to put here boolean configuration which doesn't need a server restart (also like Gitea does it, see attached)

..although I admit I should rework the UI of this part of the admin panel to make it a bit clearer

[josefandersson]

I understand where you're coming from but I'm not convinced by the mentioned issues. Registration could always be allowed when when no user exist in db no matter the settings and I don't think having to restart the server for major setting changes is unreasonable, especially on a small scale service like this one.

That said, I am not against settings in the admin panel over a config file. If options in the admin panel is the way forward then I would just make sure to be strict about options in config solely being prerequisites for service startup (which you've already done a good job of). OAuth options could be moved away perhaps? external-url? http.git-enabled? (Not sure if the libs you have used handle these being changed on the fly.)

Sorry for off-topic!

[saaremaa]

I set up the integration as described in the instructions (https://github.com/thomiceli/opengist#configure-oauth) . Connected Gitea and Opengist. When i try to log in through the user Gitea, an error occurs. Error 400 Bad Request Cannot complete user auth. What could be wrong?