thomaskoppelaar / language-rainmeter

:atom: Syntax highlighting for Rainmeter files in Atom.

todo: readme

language-rainmeter's Issues

String look

Would be nice if string only options (Text) looked like strings

Action Options

Not all of them are covered

snippets

would be nice to have them

Issue with 'MouseActionCursor' scope

Prerequisites

• You are using the most recent release of language-rainmeter
• You have checked that your issue hasn't already been addressed by an existing issue

Description

The MouseActionCursor option isn't being recognized as a 1/0 option.

Steps to Reproduce

1. Open a skin file that contains the MouseActionCursor option

Expected behavior: [What you expect to happen]
The options 1/0 value should be within the value.constant.rainmeter scope

Actual behavior: [What actually happens]
The only scope of the options 1/0 value is source.rainmeter

Reproduces how often: [What percentage of the time does it reproduce?]
100%

commands

like sublime text 2's rm package

let comments be collapsible?

any chance you make comments be able to collapse an entire section? I find it easier to organize the code that way. Also love the syntax so far, can't find anything wrong with it.

e.g.
;---CPU
;---core1
[Meter1]

Could be
;---CPU
;---core1

Or
;---CPU

Remove custom colors

Other syntax themes should decide the colors

Deprecated selector in `language-rainmeter\styles\rainmeter.atom-text-editor.less`

In language-rainmeter\styles\rainmeter.atom-text-editor.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• .source.rainmeter .section, .source.rainmeter .predefined.section => .syntax--source.syntax--rainmeter .syntax--section, .syntax--source.syntax--rainmeter .syntax--predefined.syntax--section

• .source.rainmeter .predefined.section => .syntax--source.syntax--rainmeter .syntax--predefined.syntax--section

• .source.rainmeter .variable, .source.rainmeter .predefined.variable => .syntax--source.syntax--rainmeter .syntax--variable, .syntax--source.syntax--rainmeter .syntax--predefined.syntax--variable

• .source.rainmeter .predefined.variable => .syntax--source.syntax--rainmeter .syntax--predefined.syntax--variable

• .source.rainmeter .section.variable => .syntax--source.syntax--rainmeter .syntax--section.syntax--variable

• .source.rainmeter .section.variable.arg => .syntax--source.syntax--rainmeter .syntax--section.syntax--variable.arg

• .source.rainmeter .invalid => .syntax--source.syntax--rainmeter .syntax--invalid

• .source.rainmeter .support.function => .syntax--source.syntax--rainmeter .syntax--support.syntax--function

• .source.rainmeter .support.function.constant => .syntax--source.syntax--rainmeter .syntax--support.syntax--function.syntax--constant

• .source.rainmeter .deprecated.function => .syntax--source.syntax--rainmeter .syntax--deprecated.syntax--function

• .source.rainmeter .option => .syntax--source.syntax--rainmeter .syntax--option

• .source.rainmeter .meter.style.option => .syntax--source.syntax--rainmeter .meter.syntax--style.syntax--option

• .source.rainmeter .include => .syntax--source.syntax--rainmeter .syntax--include

• .source.rainmeter .value.constant => .syntax--source.syntax--rainmeter .syntax--value.syntax--constant

• .source.rainmeter .value.constant.important => .syntax--source.syntax--rainmeter .syntax--value.syntax--constant.syntax--important

• .source.rainmeter .color.r => .syntax--source.syntax--rainmeter .syntax--color.syntax--r

• .source.rainmeter .color.g => .syntax--source.syntax--rainmeter .syntax--color.syntax--g

• .source.rainmeter .color.b => .syntax--source.syntax--rainmeter .syntax--color.syntax--b

• .source.rainmeter .color.a => .syntax--source.syntax--rainmeter .syntax--color.syntax--a

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Add continuous integration and code testing

Prerequisites

• You are using the most recent release of language-rainmeter
• You have checked that your issue hasn't already been addressed by an existing issue

Description

We should add continuous integration and automatic code integration to properly check if pull requests can be merged without issues and also to check if some of our commits break the package.

CI is no big deal as there is a example from Atom itself and it worked just fine, but the big problem is the spec as it seems that it won't detect the scopes of the general options (it will just find the source.rainmeter scope on the example string Meter=Image)

I will commit my current state on a new branch called add-ci-code-testing later and maybe someone can figure out why the hell this isnt working.

Additional Information

Guide to include CI to Atom packages: https://github.com/atom/ci
Writing specs (Guide to create automatic tests): https://flight-manual.atom.io/hacking-atom/sections/writing-specs/
Example spec file: https://github.com/atom/language-xml/blob/master/spec/xml-spec.coffee

Numbers In Strings Colored As RGBA

It seems like RGBA-like values are being colored as such, even though they aren't valid RGBA. See the below screenshot for an example.

Rainmeter section

Apply 1/0 sections on it.

Missing coverage for 'OnChangeAction' option

I just realized that I missed the 'OnChangeAction' measure option in my recent pull-request.
I can add it and submit a new pull-request if you'd like, but it's such a small change that it can probably be overlooked until further updates are needed.