thirtybees / advancedeucompliance Goto Github PK

1. “Advanced EU Compliance” v. 1.0.4, Backoffice LABELS “Tax 'inc./excl.' label”, here we can chose display the tax is included next to the product price.
2. It’s work well in homepage, if we chose YES, in front office, in homepage display “Tax included” and if we chose NO didn’t display.
3. But it didn’t work in product page: If we chose YES, in front office, product page display “Tax included”. If we chose NO, in front office, product page display “tax incl.”.
   
4. I think this need to be fix, or we can have two option, one for homepage and another to products page:
   Tax 'inc./excl.' label homepage => YES/NO
   Tax 'inc./excl.' label product page => YES/NO

When specifying CMS pages in the module I get a notice for each one I assign.

Configuration information:

php 7.4
thirtybees 1.6 (current edge)

NOTICE
Message:
Trying to access array offset on value of type null

Location:
modules/advancedeucompliance/advancedeucompliance.php line 1782
STACKTRACE
#0 modules/advancedeucompliance/advancedeucompliance.php(1782)
#1 modules/advancedeucompliance/advancedeucompliance.php(910): Advancedeucompliance->renderFormLegalContentManager()
#2 controllers/admin/AdminModulesController.php(1479): Advancedeucompliance->getContent()
#3 controllers/admin/AdminModulesController.php(1358): AdminModulesControllerCore->postProcessCallback()
#4 classes/controller/Controller.php(198): AdminModulesControllerCore->postProcess()
#5 classes/Dispatcher.php(854): ControllerCore->run()
#6 admin123/index.php(58): DispatcherCore->dispatch()

Proposed code:

foreach ($cmsRoles as $cmsRole) {
    if ((int) $cmsRole->id_cms > 0) {
        $cmsEntity = $cmsRepository->findOne((int) $cmsRole->id_cms);

        // Check if meta_title is not null and is an array
        if (isset($cmsEntity->meta_title) && is_array($cmsEntity->meta_title)) {
            $assocCmsName = $cmsEntity->meta_title[(int) $idLang];
        } else {
            $assocCmsName = $this->l('-- Select associated CMS page --');
        }
    } else {
        $assocCmsName = $this->l('-- Select associated CMS page --');
    }

    $cmsRolesAssoc[(int) $cmsRole->id] = [
        'id_cms'     => (int) $cmsRole->id_cms,
        'page_title' => (string) $assocCmsName,
        'role_title' => (string) $cmsRolesAeuc[$cmsRole->name],
    ];
}

Copy of #4 (comment)

jQuery .submit() call might be FUBAR. Would be a lot better if we just trigger a submit event instead. Maybe even remove the JavaScript check and add a backend check as well for visitors that do not have JavaScript enabled.

Module performs email template search only during installation. And it also looks only inside /mails/en directory, and ignore all theme and modules email templates.

We need to change this so module is able to detect new email templates.

I seem to have problems with the ordering process. It doesn't matter whether I just want to buy a PDF or together with a real product. Every time I get stuck in the ordering process (5 steps) when shipping, because the message comes up: "Please accept cancellation of virtual (download) articles first". However, I cannot see this checkbox anywhere.

TB 1.1.0 as well as 1.0.8 and 1.0.7

A complete description including a possible solution can be found here in the forum
https://forum.thirtybees.com/topic/3271-virtuelle-produkte-und-aeuc-modul/

See https://forum.thirtybees.com/topic/1841/aeuc-mit-unterschiedlichen-steuers%C3%A4tzen-7-und-19-vat-7-falscher-warenkorb/5 (German)

Goal is to set shipping costs with taxes in an environment with distinct per-product taxes. Some Products 7% VAT, others 19% VAT, so shipping tax percentage varies with the combination of products. With this varying percentage, shipping fees visible for the shop customers should stay constant, no matter how big the tax percentage is.

I didn't research it myself so far, but @colorful-ant wrote:

die gesamtsumme (brutto) versand ist dabei immer gleich geblieben. zum einstellen der versandkosten mit der steuer darf das auec nicht aktiviert sein, dann kann man die daten in der jeweiligen versandard eingeben und danach aeuc einfach wieder aktivieren

Translation:

The total of shipping fees stayed always constant [the way it should be]. To adjust fees with taxes, AEUC has to be deactivated. Then enter the various fees, then reactivate AEUC.

P.S.: the bug here is that the AEUC module shouldn't prohibit adjusting settings the right way. AEUC is about displaying certain additional texts to users, not about modifying / messing up tax calculations.

Reported by @colorful-ant in https://forum.thirtybees.com/topic/2129/unknown-column-id_aeuc_email-in-field-list

On “Advanced EU Compliance” we have:

When we chose “NO”, the TB didn’t display the weight of a product.
When we chose “YES”, the TB displayed the product's weight, including below 1 kg.

Two options for “YES”:

• changing the code to not show products below 1kg;
• or changing the description removing the information of products weight more than 1 kg.

Such labels can be set on Back office -> Catalog -> Products -> -> Quantities already. And these are much better, because they can be set per product, not globally.

Removing these labels from AEUC obviously also might require to do minor adjustments to the default theme, of course.

Related forum discussion:
https://forum.thirtybees.com/topic/1702/order-confirmation-email-order_conf-no-delivery-time-listed

"Warning on line 1253 in file public_html/modules/advancedeucompliance/advancedeucompliance.php
[2] count(): Parameter must be an array or an object that implements Countable"

After updating this module I constantly get 500 server error when trying to configure the module or when marking orders as shipped.

Same issue on freshly installed TB after clicking install on AdvancedEUcompliance module.

This module shows a lot of useful info but if i chose in the frontend a product with combinations it shows incorrect weight - only for default combination, so price and attributes changes depending on selected combination while weight not.

jQuery .submit() call might be FUBAR. Would be a lot better if we just trigger a submit event instead. Maybe even remove the JavaScript check and add a backend check as well for visitors that do not have JavaScript enabled.