book-thing.io's People
Forkers
elliotkim916 jorgerodriguez434 maddiereddy arisimon ginatruong gbarkin ukhlivanov jnewby91 jasoncristobal anborhan anthonypagano amyspeed bdm88 alexmccomb patriots123 wannab3d3v3lop3r djrockstar tam135 jrb5004 mblakley4 lhendriks1 edgondon sloach1218 avoss2020 patrickgus authriya connorhw dannydi12 damarriott cpedersen meredythp nick-nack-attack cmnathaniel amrvitale katemacnd disiting manduulya jroberts-68 jeremiahclaspell kurisuhehe russellmccurdy melleehall bzorkydork marlirenee santiagogomezl ozamudio51 marfriaz jmireles12 armelwl1951 miked5886 aneudya4 dan-j-gibson amjadodeh derek-arrottabook-thing.io's Issues
booksInPromise can have better name (?)
Look into adding validation of listid in db on recs endpoint
Test Coverage for /api/auth/google/callback Needs to be Provided
The google strategy uses 2 endpoints. The first is just a redirect, but the other (/api/auth/google/callback) is a little more involved and requires specific information in order to fire. Research and testing is required. Good luck.
Top level package.json doesn't need front end dependancies
Userform variable needs to be changed and move logic.
Create functions for queries that occur over and over
Get started button should not display an empty page
accesstoken to logged in state test does not map to code.
home.test
mock redux dispatch
determine if cookie can be mocked too.
Figure out precise signature for logout redirect
Create all renders without crashing test
Unify styling everywhere
Likes mechanism - backend
- A user should only be able to like a list that they have not created. (A user is only associated with a list through creation or recommendation.)
- You can only be recommended lists you did not create and you can only like lists that you were recommended once. The liked_flag is used to show if a user has already liked a recommended list and therefore is prevented from liking it again.
Save off recommedation requestor user_id to make endpoint shorter/more DRY
server/index.js lines260-262 could be a map-reduce
Likes mechanism - UI
Should be easy to use. Potentially put in a thumbs-up button or something similar.
'Should throw error upon rejection' doesn't actually throw error
Update created_flag in lists_to_users table to reflect self-creation
Look into changing forEach in rec endpoint to map/map-reduce/map(map) aka more pure morphism
Refactor usersLists endpoint
Get list and book_ids per list in one promise and then all books information in a second promise to cut out all data re-jiggering INSTEAD OF 4 table join with lots of string manipulation.
State in Recommendations component may not scale well.
Make everything responsive
Media queries
Redirects to recommendations page after signing in.
Rewire webpack config to work with logger.
Look into scaling issues of the recommendations endpoint
In particular, whether we can look up a recommendation before searching/creating anew, and any other issues of scale as more lists/books are created.
Incorrect logic in this statement
"Simply Log-in, add books, and create recommendations for other users that have read those books"
should say "Simply Log-in, add books, and create recommendations for other users that have NOT read those books"
Refactor reducer to be multiple reducers
Create function for database deletion in tests
could update list_id in first liked endpoint PUT test to be a value in the database
Create a debug mode that works with webpack
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.