Espressif_MQTT_client.cpp & OTA bug about thingsboard-client-sdk

[MathewHDYT]

I set THINGSBOARD_ENABLE_DEBUG 1 and it seems that sometimes the null character at the end of the topic is missing. Causing certain topic string to additional print a lot of garbage characters because the string is read until a random 0 byte is reached.

[TB] Received data from server over topic (v2/fw/response/0/chunk/374x"'6|h���'8�"�     ��T�)
[0;32mI (133080) MAIN: Downwloading firmware progress 91.02%
�3b�:6��)ived data from server over topic (v2/fw/response/0/chunk/375y�
[0;32mI (133280) MAIN: Downwloading firmware progress 91.26%
[TB] Received data from server over topic (v2/fw/response/0/chunk/376z^)
[0;32mI (133690) MAIN: Downwloading firmware progress 91.50%
[TB] Received data from server over topic (v2/fw/response/0/chunk/377{%,�b)
[0;32mI (133900) MAIN: Downwloading firmware progress 91.75%
[TB] Received data from server over topic (v2/fw/response/0/chunk/378|()  

But I could not reproduce the Title having missing null termination characters.

Curr: ESP32, Received: ESP32

Therefore I could not reproduce your issues. Even with the other read memory the comparison is still successful and can be downloaded like expected.
It should still be able to match the topics, because we only compare the first 22 bytes of the string. We check of the string starts with those characters v2/fw/response/0/chunk.

If that is the case we forward the data to the processing method for firmware updates. Additionally the parsing also works correctly meaning the number is still extracted correctly with atoi.

---

Additionally I am not sure your fix would solve the issue you mentioned because the firmware title is not contained in the event->topic, but the event->data instead.

Also I'm not sure it did not start because of a mismatch in the first place, because if it did it should have printed Firmware is not for us (title is different) into the console.

What I am currently assuming is that there might have been a different reason the OTA update did not start and it has either not appeared anymore or you fixed it by mistake.

[MathewHDYT]

@imbeacon Would be nice if this issue could be closed, because it seems to be stale.