thias / puppet-vsftpd Goto Github PK

Since Debian/Ubuntu support was added a couple of days ago it would be nice if the version on PuppetForge could be updated.

Hey Matthias,

in short: Ubuntu (tested in Precise) uses smbd as the Samba service name. In manifests/params.pp it is set as: samba resulting in puppet not being able to restart the service (unknown service error). I've edited:

case $osfamily {
    'RedHat': { $service = [ 'smb', 'nmb' ] }
    'Debian': { $service = [ 'samba' ] }
     default: { $service = [ 'samba' ] }
  }

to:

case $osfamily {
    'RedHat': { $service = [ 'smb', 'nmb' ] }
    'Debian': { $service = [ 'smbd' ] }
     default: { $service = [ 'smbd' ] }
  }

and it worked. Note that I was too lazy to check, whether I should change only the 'Debian' or both 'Debian' and default - I just changed both. Note that on Debian the service is named: samba, so it looks like there should be another key ubuntu specifically for this issue.

Cheers,
d-ph

Hey mate,

thanks for making this puppet module, but let's get straight to the point:

I miss local_root vsftpd.conf option in your class vsftpd. I've managed to add it by appending

  $local_root              = undef

to your class vsftpd in \modules\vsftpd\manifests\init.pp, and by appending

<% if @local_root -%>
local_root=<%= @local_root %>
<% end -%>

to file \modules\vsftpd\templates\vsftpd.conf.erb. After that I could use

class { 'vsftpd':
  # (...)
  local_root        => '/var/www',
}

in my /manifests/default.pp.

But if you ask me, the problem doesn't really lies in the fact, that "oh boy, I need option ABC, but it's not there". I think the problem lies in the way, you're trying to manage the options. Simply speaking, I would store such "highly mutable" data in a hash map, rather than trying to manage it by hand. Can you see how awful it is to add a new option? I needed to edit two different places to add just one option. And there's still more. I like the way puphpet::ini handles the problem (by an array):

puphpet::ini { 'xdebug':
  value   => [
    'xdebug.default_enable = 1',
    'xdebug.remote_autostart = 0',
    'xdebug.remote_connect_back = 1',
    'xdebug.remote_enable = 1',
    'xdebug.remote_handler = "dbgp"',
    'xdebug.remote_port = 9000',
    'xdebug.max_nesting_level = 250'
  ],
  ini     => '/etc/php5/apache2/conf.d/zzz_xdebug.ini',
  notify  => Service['apache'],
  require => Class['php'],
}

This way they covered all the xdebug options existing now and in the future.

I'm far from telling you how to code. At least I'm trying not to. In fact I don't even know how to program in Ruby, so you're my hero from the beginning. Just think about it, especially because your puppet module is #1 in the download count ("ftp" query) on the puppet forge, so more users may also have similar problem.

Or maybe there is a different way to add an arbitrary option to the vsftpd.conf through thias/puppet-vsftpd?

Kthxbb

@thias would you be willing to donate this module to voxpupuli? It is a little old but seems to work well! Our process is documented at https://voxpupuli.org/docs/#migrating-a-module-to-voxpupuli

cc @igalic

It would be great to set a path for anonymous logins.