therusskiy / ng-slide-down Goto Github PK

Hi.
Angular dependency requirement is currently ~1.2.20.
Would it be better to set >= 1.2.20 ?
When I added the dependency to my project, bower told me it couldn't resolve any version as most of my other dependencies rely on 1.4* version
Thanks

thanks for the lib.

would like to see an option to have the element opened by default with no slide down animation.

support use this package in systemjs.

You also need to put the package up on NPM.

Hey, if you are interested in converting source code for this to TypeScript, I could send a PR.
It seems that TypeScript is where things are heading in the javascript world.

Besides, it's very convenient to have it in this format for AMD purposes.
No problem though if you decide to keep things as they are.

Hi Dmitry,

On IE, an element just opened does't get its height reset to initial. After some research, IE doesn't seem to support height: initial, so I changed it to height: auto. This archives a similar effect and fixes the problem.

Here's my pull request: #2

Cheers,
Sebastien

Please add support to 1.4.x asap.

I'd like to be able to use this directive in conjonction with a table but it's not working. Tables doesn't accept height:0;.

The code appears to work fine with Angular 1.3.14, however the Bower.json file specifies Angular '~1.2.20', meaning it must be less than 1.3

Is there a reason this library cannot support Angular 1.3? If not, can the Bower file be updated accordingly?

JS is not my speciality, but I'm willing to help make the update via pull request if necessary/desired.

Hi,

I really like this component and use it a lot, but as I'm migrating my project to Angular/Ionic 2, I would like to have it for that version.

Would that ever be possible ?

It would be nice to be able to set some global defaults, for example the default duration is way too long for my taste and I would not like to override it every time.

I'm using angular-material.

<md-card>
card header here
 <md-card-content ng-class="vm.edit ? '' : 'hide-char-counter'; vm.collapse ? 'no-padding': ''" ng-slide-down="!vm.collapse" lazy-render>Mycontent</md-card-content>
</md-card>

md-card-content, sets a padding of 16px. When my card is collpased, I have an undesired result because md-card-content's padding is visible even though it's collpased.

My solution was to set padding:0 if it's collpased. But the class is never added with ng-class and it's because of how you change the collapsed variable.

Maybe the simple solution is to wrap it in a timeout.

Also if ng-slide-down is true on dom load, I would like it if it didn't do the slide down animation. It happens fast, but it still happens and looks sloppy on page load, with or without lazy-render.