Coder Social home page Coder Social logo

thermatk / fasthub-libre Goto Github PK

View Code? Open in Web Editor NEW

This project forked from k0shk0sh/fasthub

382.0 382.0 21.0 18.55 MB

Libre fork of FastHub, the ultimate GitHub client for Android.

License: GNU General Public License v3.0

JavaScript 0.25% CSS 3.99% Java 83.64% HTML 0.11% Kotlin 12.01%

fasthub-libre's People

Contributors

aadithyabk avatar aliangliang avatar ardacebi avatar astro36 avatar azumukupoe avatar caiorrs avatar cozyplanes avatar daniel-stoneuk avatar dedepete avatar dikiaap avatar dreamersoul avatar eygraber avatar failex234 avatar heinrichreimer avatar jediburrell avatar jonathan-caryl avatar kallydev avatar kejn avatar kutsan avatar maple3142 avatar mistermantas avatar ptt-homme avatar raffaele74 avatar rainer-lang avatar stargamers avatar the-cybersapien avatar thermatk avatar veyndan avatar vvb2060 avatar yakov116 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

fasthub-libre's Issues

PRs can display "✓ This PR can't be merged now."

FastHub Version: FastHub-Libre 4.6.6
Android Version: Android 8.0.0 / OxygenOS 5.0.1
Device: OnePlus 3T

Problem description

PRs that could be merged but are blocked by e. g. a missing required review show a green check mark with the text "This PR can't be merged now". That's either a bug or a very confusing design choice.

screenshot_20180512-151428

Wrong line gets outlined on PR Review

FastHub-Libre Version: 4.6.3

When commenting on a line of a PR the line above the selected one gets used when submitting.
This is especially bad as the other clients show the selected line and the one above that when multiple are shown.
Currently the one which is referred to is therefore not visible.

Error Toast when Creating an Issue

Simply unable to create new issues. Always getting an error toast upon hitting the 'Send' icon.

-->

FastHub Version: 4.6.1
Android Version: 5.1
Device Information: CM 12.1


Full-screen Markdown editor: misleading navigation description / corresponding navigation item missing

When (for example) writing a comment on an issue, one can select the little "full screen" symbol on the bottom right to get to the full screen markdown editor.

  • There is no corresponding symbol at the same place to leave the editor (go back to the small one), which might be more intuitive
  • The tickmark at the top right, which actually does go back to the original input field, is hinted "Submit" (long press to view) which is misleading as it does not submit the comment but only goes back to another editor

Redundant buttons on release notes

When viewing release notes, two buttons are presented at the bottom. “OK” and “Cancel”.

They both seem to do the exact same thing, dismiss the release notes. Maybe we can do away with one of them?

Screenshot attached.

Markdown preview: different symbol for "close preview"

At different places (e.g. "small" and "full screen" comment editor (text field)) one can go to markdown preview by clicking on the eye symbol. Closing the preview and going back to the editor is achieved by clicking the same symbol. This is a bit confusing; a symbol representing an editor would be more intuitive.

Reaction (smiles) applied to issues not saved

When I add "smile" to any issue as reaction, it not saved then (look like not sent POST querry to server immediatly)

Details

FastHub Version: 4.6.0

Android Version: 6.0

P.S.: I use FastHub Libre on slow connection (mobile 2G network).

Light splash screen with dark theme

FastHub-Libre Version: 4.6.2
Android Version: 8.0.0 (SDK: 26)
Device Information:

  • Manufacturer: OnePlus
  • Brand: OnePlus
  • Model: OnePlus5T

The splash screen always appears with a white background when first launching the app, even with the dark theme enabled. It would be better to check for which theme is selected before displaying the splash screen, and then show a light or dark one depending on the theme that the user chose. Or to replace the splash screen image file with a different one when the theme is changed in the settings.

Profile does not update

FastHub-Libre Version: 4.5.5
Android Version: 5.1.1 (SDK: 22)
Device Information:

  • Manufacturer: ZUK
  • Brand: ZUK
  • Model: Z1

The profile data of the currently logged in user is not updated, if it is updated through another client.

There is no way to "pull down" or anything similar to initiate a refresh.

Detach repo

Can you please detach this repo from the not Google-play-only version?

You can this either do it manually or – which I recommend – just contact the GitHub support to do it for you.

This…

  1. shows that this is a real maintained project and not just a repo of someone who (once) made a pull request
  2. can (and IMHO should) still link to the original repo/website/author/… for crediting them, but you can do so in better ways (in the Readme, wiki or so)
  3. allows searching in this repo on GitHub and
  4. it just looks much nicer

FR Autoscroll when commenting

FastHub-Libre Version: 4.6.6
Android Version: 5.1.1 (SDK: 22)
Device Information:

  • Manufacturer: TP-LINK
  • Brand: TP-LINK
  • Model: C5L

It would help if when commenting e.g. an issue the comment would be autoscrolled to, when sent.

Sent from my C5L using FastHub-Libre

Tor support with Orbot

Is there a possibility to integrate tor support into Fasthub-Libre? I figure that it should be fairly easy to do.
You only have to let the client redirect the traffic too 127.0.0.1/localhost and use port 9050 (for SOCKS) or 9040 (for transparent). It would be great for people who want to contribute to their favorite projects while keeping themselves safe and anonymous.

Profile image not updated

FastHub-Libre Version: 4.6.6
Android Version: 7.1.1 (SDK: 25)
Device Information:

  • Manufacturer: LENOVO
  • Brand: Lenovo
  • Model: TAB4 8

Changes to profile picture are not detected. Clicking on user's own profile image loads correct one from GH but app continues to display previous one.

Gitea/Gogs support

It would be great to have local Github-like services to be accessed within this app.

(Upstream seams to have declined it k0shk0sh#1459 - only applies for gitlab)

Changelog shown on every start of app

FastHub-Libre Version: 4.6.6
Android Version: 8.1.0 (SDK: 27)
Device Information:

  • Manufacturer: LGE
  • Model: Nexus 5X

To reproduce:

  • run app, tap 'ok' on changelog that comes up

  • force close or wait for android to stop app (several minutes/hours)

  • run app again, changelog is displayed despite there being no updates since the last time it was shown

No text visible

FastHub-Libre Version: 4.5.5
Android Version: 5.1.1 (SDK: 22)
Device Information:

  • Manufacturer: Sony
  • Brand: Sony
  • Model: Xperia Z1 Compact

In the app I cannot see any text in an issue

For example

AlbrechtL/welle.io#165

In the browser it works

Cannot see a PR I reviewed

FastHub-Libre Version: 4.5.5
Android Version: 6.0 (SDK: 23)
Device Information:

  • Manufacturer: EVOLVEO
  • Brand: EVOLVEO
  • Model: EVOLVEO StrongPhone G4

I was requested to review a PR and I left a review requesting changes (all through github's web interface). I cannot see the PR in ForkHub

FR: Scroll to the comment from comment notifications

FastHub-Libre Version: 4.5.5
Android Version: 7.1.2 (SDK: 25)
Device Information:

  • Manufacturer: Google
  • Model: Pixel XL

Selecting a comment notification opens the pull request/issue at the top of the comments list. It would be great if it scrolled to the comment itself, like opening a comment link (e.g. from a notification email or the GitHub website) does.

Crash when issue contains pictures

Latest version from fdroid on Android 7.1

11-27 18:28:23.619 9585-9585/com.fastaccess.github.libre E/AndroidRuntime: FATAL EXCEPTION: main
                                                                           Process: com.fastaccess.github.libre, PID: 123
                                                                           java.lang.SecurityException: ConnectivityService: Neither user 1234 nor current process has android.permission.ACCESS_NETWORK_STATE.
                                                                               at android.os.Parcel.readException(Parcel.java:1684)
                                                                               at android.os.Parcel.readException(Parcel.java:1637)
                                                                               at android.net.IConnectivityManager$Stub$Proxy.getNetworkInfo(IConnectivityManager.java:1225)
                                                                               at android.net.ConnectivityManager.getNetworkInfo(ConnectivityManager.java:910)
                                                                               at com.fastaccess.helper.AppHelper.isDataPlan(AppHelper.java:190)
                                                                               at com.fastaccess.helper.PrefGetter.isAutoImageDisabled(PrefGetter.java:466)
                                                                               at com.fastaccess.provider.timeline.handler.DrawableHandler.handleTagNode(DrawableHandler.java:38)
                                                                               at net.nightwhistler.htmlspanner.HtmlSpanner.handleContent(HtmlSpanner.java:269)
                                                                               at net.nightwhistler.htmlspanner.HtmlSpanner.handleContent(HtmlSpanner.java:262)
                                                                               at net.nightwhistler.htmlspanner.HtmlSpanner.handleContent(HtmlSpanner.java:262)
                                                                               at net.nightwhistler.htmlspanner.HtmlSpanner.handleContent(HtmlSpanner.java:262)
                                                                               at net.nightwhistler.htmlspanner.HtmlSpanner.fromTagNode(HtmlSpanner.java:219)
                                                                               at net.nightwhistler.htmlspanner.HtmlSpanner.fromHtml(HtmlSpanner.java:174)
                                                                               at com.fastaccess.provider.timeline.HtmlHelper.htmlIntoTextView(HtmlHelper.java:48)
                                                                               at com.fastaccess.ui.adapter.viewholder.TimelineCommentsViewHolder.bind(TimelineCommentsViewHolder.java:185)
                                                                               at com.fastaccess.ui.adapter.IssuesTimelineAdapter.onBindView(IssuesTimelineAdapter.java:86)
                                                                               at com.fastaccess.ui.widgets.recyclerview.BaseRecyclerAdapter.onBindViewHolder(BaseRecyclerAdapter.java:88)
                                                                               at com.fastaccess.ui.widgets.recyclerview.BaseRecyclerAdapter.onBindViewHolder(BaseRecyclerAdapter.java:20)
                                                                               at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:6482)
                                                                               at android.support.v7.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:6515)
                                                                               at android.support.v7.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:5458)
                                                                               at android.support.v7.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:5724)
                                                                               at android.support.v7.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:285)
                                                                               at android.support.v7.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:342)
                                                                               at android.support.v7.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:358)
                                                                               at android.support.v7.widget.GapWorker.prefetch(GapWorker.java:365)
                                                                               at android.support.v7.widget.GapWorker.run(GapWorker.java:396)
                                                                               at android.os.Handler.handleCallback(Handler.java:751)
                                                                               at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                               at android.os.Looper.loop(Looper.java:154)
                                                                               at android.app.ActivityThread.main(ActivityThread.java:6186)
                                                                               at java.lang.reflect.Method.invoke(Native Method)
                                                                               at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
                                                                               at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

Markdown rendering broken (or not): display images and follow links

FastHub Version: 4.6.6 (github.com and Enterprise)
Android Version: 8.1.0 (LineageOS 15.1-20180409-NIGHTLY-bullhead)
Device Information:

  • MANUFACTURER: LG
  • BRAND: Nexus
  • MODEL: 5X

I am keeping a wiki (vimwiki) written in markdown in a git repository, hosted on GitHub Enterprise.

I encountered two issues with the rendering.

images

Images included in a markdown file with ![image](image_location.png) are not getting displayed, but can be opened manually in FastHub-Libre.

Bug or feature? Any plans on supporting this feature?

link following

Raw markdown file used here:

# Wed 2018-04-11

If I open the markdown file through FILES, the file opens and gets rendered correctly.

render

However, if I try to follow a markdown link in a rendered file (all the links are in the markdown format [link](link.mkd)), I get the error No file found/No data available.

no_file_found

If I then open the file in the browser with Open in browser, the file gets rendered in GitHub (Enterprise) correctly (so Fasthab has the correct link/location):

browser

Mark notifications as read only when loading succeeds

FastHub-Libre Version: 4.5.5
Android Version: 7.1.2 (SDK: 25)
Device Information: ...


Sometimes I have the problem that I open a notification and it shows me a black screen with loading error (just some network issue, so I would usually just retry it), but in the background (with android notification) it marks the notification as read on github and in the app, so when I press "back" to repeat the losing I just cannot find the entry anymore.

app closing

FastHub-Libre Version: 4.6.3
Android Version: 7.1.1 (SDK: 25)
Device Information:

  • Manufacturer: WIKO
  • Brand: WIKO
  • Model: U FEEL PRIME

The app stops working when I click on "notifications" in "settings"

New right aligned drawer

FastHub-Libre Version: 4.6.3
Android Version: 8.1.0 (SDK: 27)
Device Information:

  • Manufacturer: LGE
  • Brand: lge
  • Model: Nexus 5

The scroll bar interferes with the new drawer.
Pulling out the drawer makes me scroll down through my feed.

Maybe we can implement a different way to access this drawer?

Update

Can you please update your fork to the latest version (which is 3.2 at the moment)? This version brings a better Russian translation, compared to 3.0.

Restore backup.json fails

FastHub-Libre Version: 4.6.1
Android Version: 7.1.2 (SDK: 25)
Device Information:

  • Manufacturer: motorola
  • Brand: motorola
  • Model: Moto G

Upon selecting restore from settings, the backup.json file is shown greyed out. Fine, so when I tried to configure the settings manually, upon selecting "Customisation" or "Behaviour" from setting, the app force closes.

Document the changes to upstream

Especially:

  • Why was it forked?
  • What (bad/tracking) features have been removed?
  • What functionality is thus not available?
  • Any other changes??

Put it into the Readme or so.

Unable to install latest releases on Android 8.1

FastHub-Libre Version: 4.5.5
Android Version: 8.1.0 (SDK: 27)
Device Information:

  • Manufacturer: Google
  • Model: Pixel 2 XL

Hi, the app installs perfectly fine from when I download it from F-Droid, but F-Droid doesn't have the latest version, and I am unable to download it from the release page (.app doesn't open up in system installer)

Any suggestions?

Thanks!

Horizontal lines are black for dark themes too

FastHub-Libre Version: 4.6.6
Android Version: 7.1.2 (SDK: 25)
Device Information:

  • Manufacturer: bq
  • Brand: bq
  • Model: Aquaris M5

I think this should be better in white. I'm talking about this kind of lines:


Feature request: Set avatar from app

FastHub-Libre Version: 4.6.1
Android Version: 7.1.2 (SDK: 25)
Device Information:

  • Manufacturer: motorola
  • Brand: motorola
  • Model: Moto G

It would be great to be able to set Profile Picture of account from within the app.

PRO FEATURES

Hey buddy, thanks for the continuous work on this fork.

I have noticed that you enabled all FastHub PRO FEATURES for FREEEEE which I respect that you didn't consider making money out of it, however I have included awhile ago that no FORK should enable or use these features as its something i'm making living out of it and by you making it free for all from different website will definitely hurt me and the buyers who bought these features from the Playstore.

So, could you please remove all of these features from your fork?

PDF

FastHub-Libre Version: 4.6.6
Android Version: 7.0 (SDK: 24)
Device Information:

  • Manufacturer: HTC
  • Brand: htc
  • Model: One A9

PDF viewing ist broken. I can not view or download them to view them afterwards.

Error toast when commenting a pr, but comment is sent

FastHub-Libre Version: 4.6.1
Android Version: 7.1.2 (SDK: 25)
Device Information:

  • Manufacturer&Brand: OnePlus
  • Model: OnePlus

Since the last update, I get a toast "Error while communicating with the server" every time I comment on an issue or pr, but the comment is actually sent.

Does not render markdown in "Projects" section

FastHub-Libre Version: 4.6.6
Android Version: 8.0.0 (SDK: 26)
Device Information:

  • Manufacturer: Xiaomi
  • Brand: xiaomi
  • Model: Mi A1

Hey,
I just noticed that the app does not render markdown in the Projects section of the app. I have a card with some markdown in it under my lililte fork.

Would you please add it in?

Thank you.

right sidebar breaks scrolling

I just updated fasthub libre from fdroid.

Is there a way to disable the sidebar comming from the right?
When scrolling by touching the scroll-bar handle (the blue thing), for example when viewing a list of PRs or issues, a very slight move to the left will trigger the sidebar to pop up and overlay the scroll handle and scrolling stops, this is very annoying, especially when scrolling through very long reports. :/

FastHub Version: 4.6.3
Android Version:6.0.1
Device Information:nexus 5

App state not saved, when editing issue

Currently only tested when adding issue and editing it,
For example,

  • open issue
  • add title
  • click on body
  • switch to other app,
  • click home
  • select fasthub-libre

Fasthub-libre opens to home screen, main feed.
Whereas it should open back to body of issue you where working on

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.