therealmik / pyrdiff

Python rdiff/rsync implementation (for experimental/learning purposes only)

pyrdiff

Python rdiff/rsync implementation (for experimental/learning purposes only)

pyrdiff's Issues

Issues with Python 2.6.6

Hello!

I read your rdiff implementation in pure Python and it's amazing! It's really awesome work! Did you execute performance tests? I do it with original rdiff and they are really worst - librsync/librsync#6 :(

Could you add compatibility with Python 2.6?

python pyrdiff.py 
  File "pyrdiff.py", line 344
    print("Usage: {0:s} <command> [options ...]".format(sys.argv[0]), file=sys.stderr)
                                                                          ^
SyntaxError: invalid syntax

I fix this lines but scripts still not working:

python pyrdiff.py signature /vz/private/1202/root.hdd/root.hdd /tmp/result.signature
Traceback (most recent call last):
  File "pyrdiff.py", line 399, in <module>
    main()
  File "pyrdiff.py", line 375, in main
    Signatures.from_basis_file(basisfd).write(sigfd)
  File "pyrdiff.py", line 184, in write
    write_int(fd, RS_SIG_MAGIC, 4)
  File "pyrdiff.py", line 142, in write_int
    buf = i.to_bytes(nbytes, 'big')
AttributeError: 'int' object has no attribute 'to_bytes'

Thank you!

Performance fix for delta generation

Hello!

I plans to test delta generation performance but found this in your code:

268: buf = changedfd.read() # Just read the whole damn file into memory

Could you fix this code to real file reading instead putting whole file to memory?

Thank you so much :)