thephilderbeast / prisonpicks Goto Github PK

Improve unit test code coverage as far as practical, with an aim of 80%

the feature/Unit_tests branch is being used for this.

The XPick/PoP should still give experience to players for breaking ores inside their cells/non Worlguard regions

cc. Drekryan - fix this

its broken and depending on where it sees a higher level block it will then propogate through the rest of the blocks being mined.

Currently Unbreaking 2+ is being treated as Unbreaking 1 this should be fixed

Add a command to reload the plugin so the whole server dosent have to be realoaded

The Inventory Full Notification should be moved to AutoPickup in full and the /fullnotify command will be removed entirely. The reasoning for this is to not duplicate the code across both plugins for both AutoBlock and non-AutoBlock as it seems messy. Also creating an API on the prisonPicks side for AutoBlock to use could cause performance problems due to the rate it would have to check to see if the settings have been changed. From a code standpoint the prisonPicks plugin should not care whether inventory space is available or not. It should always try adding the item regardless and let AutoPickup handle what to do with it. Whether that may be deleting excess items or dropping them to the ground.

This bug has been reported by some people but I havent been able to reproduce it. Ill have to take a further look into why this would happen

Add config options for colors of the repair messages

Add config option to set the priority of blocks for the pop/xpopAdd config option to set the priority of blocks for the pop/xpop

The AOE radius code currently isn't very intuitive and makes getting desirable results difficult. This should be fixed so AOE radius customization can be added in the future.

AutoPickup should be a soft dependency. Where we use it if the plugin is available but do our own handling if the AutoPickup plugin cannot be found.

Currently we will crash without the AutoPickup plugin. This plugin SHOULD be able to work without AutoPickup available.

allow the server admin to configure explosive picks to have diffrent radii and have multipul versions per server

Everytime I try and use this plugin on any of my servers, it says there is an internal error?! Any suggestions on trying to fix that?

auto pickup needs to be added as a hard dependency

the code needs to be checked to reduce the amount of public access on vars and methods.

add java doc comments to our methods to allow us to provide docs to new devs that want to work on this.

we should probably improve the comments in the code as well to explain things

add a config file to allow server admins to adjust the settings for the plugin

enable/disable each pick type
set aoe radius (per pick?)