theoness1 / eatinganimation Goto Github PK

The mod break foods with custommodelsdatas (it breaks only in inventory, in hand and on floor it have the custom texture), can you fix that please

I've seen this bug reported with Optifine/Optifabric to a but to report it in a more concise way, I'll do so here.

As far as I've seen, CIT replacements are bugged in the inventory.
Strangely enough, they seem to render with their appropriate cit textures elsewhere.
Screenshots demonstrating this are below: (if it works)

the Redstone in the Hotbar appears with the regular default texture, however, In the player's hand (both first and third person), and as a dropped item, the texture changes following the CIT of the resource pack

additionally, and possibly related, food animations also don't render in the inventory.
through basic testing, the type of CIT doesn't appear to matter, just the fact that the item has changed.

One of my favorite mods. Please port it to 1.18.2 so that I can finish my collection of mods. Indirectly meaning to update the mod sooner every time a new minecraft version is released.

Game refuses to launch on Fabric 1.20.6 because of hard lock on version number for current build of Eating Animation.

Maybe a way to do foods from different mods could be something where you just remove a generic part of the model with every "bite". For example, you show a full square of, say, cheese. In the first bite, you render everything. In the second bite, you only render the bottom 3/4. in the third bite, you render the bottom half, etc. This would be only affecting the model of the food. That way, it would also work well with resource packs. I think it would be kind of similar to chisels and bits (I think) they don't hard code every possibility (I think), it is probably more of a "remove X part from model of block"

Example: (4x4 texture?)
[] means a pixel
{} means no pixel

1st "bite":

[][][][]
[][][][]
[][][][]
[][][][]

2nd "bite":

{}{}{}{}
[][][][]
[][][][]
[][][][]

3rd "bite":

{}{}{}{}
{}{}{}{}
[][][][]
[][][][]

I hope this made sense :)

Can you add eating animation forThe Bumblezone's mod food?
This mod adds 5 food items:
Shugar water bottle
Bee bread
Honey crystal shard
Bee soup
Royal jelly bottle

Something about the way the mod uses CIT makes it so certain resource packs that rely on CIT data, such as Xali's Enchanted Books, don't show custom textures in the inventory. I've only tested this with Xali's Enchanted Books, but I imagine this same issue would occur with other resource packs that rely on CIT.

Users may be confused when they see that it depends on fabric, not knowing that it's referring to the Fabric API.

As of Minecraft 1.19.2, Fabric API's mod ID has changed from fabric to fabric-api. When backporting from 1.19.2 to earlier versions, you must alter the depends section of your fabric.mod.json to expect fabric.

From https://fabricmc.net/wiki/tutorial:setup#mod_setup

You should also add the Fabric API dependency for releases on CF and MR

Port for fabric 1.18.2

When I was making drinkable items using "drink" "drinking" it doesn't seem to work or show the assets changing. it just shows the normal layer image. I even tried replacing it with "eat" "eating" like i saw in other supported mods in the jar but nothing was working. I've noticed farmer's delight drinks do not animate, as well as any other drinks besides the potion.

Golden carrots are (arguably) the best food item in the vanilla game, so it's unfortunate that golden carrots are the only vanilla food without an animation. Would love to see an animation added :)

My suggestion is, to add support to all foods. How?

1. For any tick the food takes to it, the mod will take the previous tick's texture, and add delete some blobs. The blobs are starting to generate in texture boundaries, and move inwards. The blobs got a higher chance to occur the far it is from the player hand.
2. Delete the blobs (make a texture with the blobs as transparent)
3. Show it.
4. The blobs vary. They're smaller the healthy the food is (gives more hunger points) and occuring more the light it is (how much time it takes to it the food)
5. When food with vanilla texture, (for example: bottle, bowl) the pixels of container will not disappear.
6. Mods can add to the tag food_containers items that will be counted as bowls.

There is no version with CIT textures fixed, I ask you to fix the texture issue for this version as soon as possible to solve the problem that the inventory does not show the texture.

I was wondering if you would be open to adding support for the fish meats added by Hybrid Aquatic

These are:

• (Cooked) Fish Meat
• (Cooked) Small Fish Meat
• (Cooked) Tentacle
• (Cooked) Crab Meat

the link it redirect to is this link
screenshot

the correct link that it should redirect to is this link

Since Farmer's Delight is supported, can you add support for Expanded Delight and Nether's Delight for Fabric?

I was going through a my list of mods and thought you might be interested in a small list of mod compatibility ideas:

Immersive Weathering (4 items)
BetterNether (5 food items and 2 "Medicine" items)
BetterEnd (14 items)
Bewitchment (9 items?)
Bewitchment Plus (just Dragon Fruit?)
Terrarian Slimes (just Apple Pie and Ice Cream)
Go Fish (40 items)
MobZ (just Thick Rotten Flesh)
Nears (10 items)
Better Animals Plus (15 items)
Adorn (4 items)
Create [Fabric] (5 items?)
Reaping Mod (1 item)

But this are only ideas (for 113 items, yes...) for 1.18.2.
And thanks for awesome mod!
P.S.: "?' means "idk exactly".

Basically, it would be cool if it was possible to (since based on the mod compatibility ideas post you can't have it in the actual mod) add compatibility for edible items from other mods.
Like the textures could be made manually (by anyone really) and then people (unless it's just me) can stop being annoyed that only half of their foods animate when eaten.
Basically I want a way to add support for modded foods (and non-foods that are edible) myself so I can stop having only half of my foods animated.

Though this suggestion is on the Fabric version, obviously it would be nice to have on forge, too

It seems that this mod won't work with popular resource pack from vanilla tweaks
my guess is in unobtrusive tab-smaller utilities resource pack is the one causing this compatibility issue
can you please fix this issue since many of my friends and I have this resource pack
just to be sure I upload all of my resource pack selected in vanilla tweaks so you can recreate this issue
without this pack mod works
stay sus :)
VanillaTweaks_1.18.zip

I have been working on a 1.12.2 version of this mod (1.12.2 EatingAnimation). If anyone wants to help, the project is open.

Things that have been done:
-Made all eating textures for 1.12.2
-Set to java 8 instead of java 17.

Things that need to be done:
-Fully convert compilation from fabric 1.19.4 to forge 1.12.2.
-Convert the model names and json file contents to point to the 1.12.2 eating textures.
-needs to be tested on the apple and baked potato before continuing.

I'm not able to see the eating animation although i've disabled every other mod (I'm in version 1.20.1

Hello,

I have a resourcepack making 2d items have different textures with CustomModelData. The texture applies to the item when it is being held in your hand, dropped on the ground, or placed in an item frame.

However, the item does not have its texture applied in the inventory. Upon removing EatingAnimation from my mods list, the texture was applied correctly.

Version: MC 1.20.4
EatingAnimation: 1.9.61

With Eating Animation installed:

Without Eating Animation installed:

So I have recently found a problem that the Golden Carrot eating animation isn't loaded while the others works fine. I have tried opening the mod file as archive (7-Zip) but the golden_carrot.json file and the "children" are just perfectly fine.

Sidenote: I have once tried to retexture the Enchanted Golden Apple eating texture to sync with the Visual Enchantments texture pack and it worked once, but the second time when I reload the pack, it got the same issue as the current one above.

they were working just fine until i logged in today and now the golden carrots don't have their proper animation anymore? i've not changed anything in my folder

you cant drink from a sealed bottle

All 40 edible food items in the game (I'm excluding cake, obviously) has an eating animation except pufferfish.

Steps to reproduce:

1. Install the mod
2. Eat a pufferfish
3. Eat any other food
4. Notice that pufferfish is the the only food item that does not have an eating animation.

Expected results:

• Pufferfish also has an eating animation when eaten.

I have tried adding an animation using a resource pack, but that doesn't work. I have no knowledge of Minecraft modding, but I assume there is a part of the mod that stipulates what food is affected, and pufferfish has been excluded by accident.

While you can use CustomModelData with eating animations in the hand and third person, the inventory item does not respect the CustomModelData predicate.

Inventory item will ONLY display the default item model, not applying any predicates.

Suggestion: Grab the Inventory model from the predicate "eating" when it is 0

Steps to Reproduce:
Install this Test Resource Pack
CustomModelData EatingAnimation.zip
Ingame, run the following Commands:
/give @s bread = Default Bread
/give @s bread{CustomModelData:1} = Beef Taco
/give @s bread{CustomModelData:2} = Pork Taco
/give @s bread{CustomModelData:3} = Chicken Taco
/give @s bread{CustomModelData:4} = Fish Taco
/give @s bread{CustomModelData:5} = Beef Wellington
Notice the items in the inventory all use the default model present in bread.json instead of the CustomModelData versions, but inhand and inworld, they appear properly.

Hi, love the mod and look of it!

I was wondering if you'd be willing to add support for the foods added by the Naturalist mod.

These are:

• (Cooked) Venison
• (Cooked) Lizard Tail
• (Cooked) Duck
• (Cooked) Bass
• (Cooked) Catfish
• Cooked Egg

the title explains it.

anytime i enable my vanillatweaks resource pack, the animations for stews and golden carrots stops working.

any ideas?

I noticed that if you have food with a custom item texture specified by said items NBT while you have this mod installed the item texture will revert to the base texture of the item in the inventory. Holding the item gives you correct texture. Disablinging the resourceback provided by the mod doesn't change anything.

Ideally it would be nice if the item references a custom model in the NBT the mod just ignores it. Alternatively make it so disabling the resource pack disables changing any textures rather than needed to reload the instance to diable the mod altogether.

I don't know why but the integrated resource pack named "supporteatinganimation" in resource pack folder of the mod is automatically active and i didn't find any other way to deactivate it than to delete it from the jar.
I tested with clean fabric install with only your mod.

As the title says, I want to help people to change the textures by making a resourcepack guide until all textures can be dynamically changed.
I have template files, and previous great experience with resourcepacks. I would gladly make said guide. Maybe on this repository's Wiki page, seeing as there is none.

(I don't see a tag/label option, so see this issue as a suggestion/improvement.)

Add the tag for Minecraft versions 1.19.1 and 1.19.2 on Modrinth. The 1.9 mod version for fabric works perfectly fine in these Minecraft versions, as I tested.

Hiya, thanks for making this really cute mod.

Botania has two food items that might be worth animating:

• Mana cookies, with the same animation style as regular cookies
• Fruit of Grisaia. For this, it could be cool to have the apple animation go halfway (almost to the core), but then reverse, since the fruit isn't actually consumed.

Hi there!

In version 1.3.7 of Farmer's Delight (Fabric), posted on Modrinth on Nov 22, 2022, a couple new food items were added which so far are not supported by Eating Animations.
These food items include: glow berry custard, salmon roll, cod roll, kelp roll, kelp slice roll, mushroom rice and bone broth.

Could you perhaps add support for these as well?

Tools and Weapons should be textured differently to vanilla textures
Pack: https://www.curseforge.com/minecraft/texture-packs/visual-enchantments

Golden carrots are the primary endgame food item in mc, so its important they have an animation.

Title. It's one of the best mods of all time imo. It's for Fabri 1.20.1/1.19.2

This mod has a little incompatibility with Custom Crops.
https://polymart.org/resource/customcrops.2625

Custom crops have sprite as apples. So holding in hand or showing in item frames it works fine, but in the inventory all crops are apples, which is a little bit confusing.

If you have a resource pack that adds CIT (Custom Item Textures) to potions using Optifine, the potions in the GUI will not use the CIT provided by the resource pack. The potions held in the players hands, on the ground, and in item frames will use the CIT, but in the inventory, they will not.

The mod doesn't effect all CIT. As shown in the clips, CIT for axolotl buckets are unaffected.

I'm unsure why the mod breaks potion CIT considering the mod doesn't give potions a drinking animation.

Videos:
Without EatingAnimations mod.
With EatingAnimations mod.

I love how you've added compatibility with Farmer's Delight, it really is an awesome update!

When you have the time to spare, could you maybe add compatibility with its expansion, Expanded Delight?

You can find said mod here - Modrinth or here - CurseForge

Thank you very much for your work ❤️

Hey, it's me again.
I really liked your mod support for The Bumblezone so, that would be nice if you added support for Alex's Mobs mod.
I know that its gonna be hard for u bc because this mod adds 20 more food items.
Here's the list of food items that this mod adds:
• Maggot;
• Banana;
• Lobser Tail Raw/Cooked;
• Sopa De Macaco (Don't question it);
• Moose Ribs Raw/Cooked;
• Fish Oil;
• Shrimp-Fired Rice;
• Boiled Emu Egg;
• Kangoroo Meat Raw/Cooked;
• Kangoroo Burger;
• Gongulidia;
• Cosmic Cod;
• Rainbow Jelly;
• Catfish Raw/Cooked;
• Flying Fish (Just raw fish, no cooked form);
• Mosquito Repellent Stew.