themegrill / colormag Goto Github PK

Need to add CSS class for active category menu item.

PHP 8.1.11
ColorMag Version: 1.0.0

[OK] I stop the headlines
[NOK] Hover over the headlines => headlines start again (at least the icon is then wrong too)
[NOK] I stop again the headlines ...

I zipped the screencast using ZIP
2022-11-15 21-51-59.zip

Thank you for this great theme

A user of Colormag pro has identified an issue where the Frontpage slider widgets won't work (nothing will appear) as expected when added inside of a SiteOrigin Page Builder instance - SiteOrigin Layouts Block, Layout Builder, SiteOrigin (Widgets Bundle) Layout Slider. I've come up with a fix to this but it appears the underlying code isn't in this repo so I'm not able to submit it. I've included the fix below. I would be happy to submit this fix to any repo, or for someone else to submit it on my behalf.

Open colormag-pro/inc/helper-functions.php and find:

if ( ! function_exists( 'colormag_elementor_active_page_check' ) ) :

	/**
	 * Check whether Elementor plugin is activated and is active on current page or not.
	 *
	 * @return bool
	 *
	 * @since ColorMag 2.2.3
	 */
	function colormag_elementor_active_page_check() {
		global $post;

		if ( defined( 'ELEMENTOR_VERSION' ) && get_post_meta( $post->ID, '_elementor_edit_mode', true ) ) {
			return true;
		}

		return false;
	}

endif;

Add after:

if ( ! function_exists( 'colormag_siteorigin_panels_active_page_check' ) ) :

	/**
	 * Check whether SiteOrigin Page Builder plugin is activated and is active on current page or not.
	 *
	 * @return bool
	 *
	 * @since ColorMag 
	 */
	function colormag_siteorigin_panels_active_page_check() {
		global $post;

		if ( defined( 'SITEORIGIN_PANELS_VERSION' ) && get_post_meta( $post->ID, 'panels_data', true ) ) {
			return true;
		}

		return false;
	}

endif;

Replace every instance of the following conditional:
if ( is_active_widget( false, false, $this->id_base ) || is_customize_preview() || colormag_elementor_active_page_check() ) {

With:
if ( is_active_widget( false, false, $this->id_base ) || is_customize_preview() || colormag_elementor_active_page_check() || colormag_siteorigin_panels_active_page_check() ) {

Seems like the menu is styled via the #menu-primary id, which is always dynamic. Hence, if the menu name is different then, CSS will not be applied to.

Google Plus Icon is Broken

Currently:
<li><a href="#" target="_blank"><i class="fa fa-google+"></i></a></li>

Should be:
<li><a href="#" target="_blank"><i class="fa fa-google-plus"></i></a></li>

Hello, congratulations for you theme, I just passing by to make two recommendations:

1- integrate the forum-based file attachment format like image below

2 Remove the Google+ social network, given that this social network is extinct.

The Unique Post System setting will result in a fatal error message when a widget that uses it is added using SiteOrigin Page Builder.

Fatal error: Uncaught TypeError: array_merge(): Argument #1 must be of type array, null given in /home/***/public_html/wp-content/themes/colormag-pro/inc/template-tags.php:167 Stack trace: #0 /home/***/public_html/wp-content/themes/colormag-pro/inc/template-tags.php(167): array_merge() #1 /home/***/public_html/wp-content/themes/colormag-pro/inc/widgets/colormag-featured-posts-slider-widget.php(171): colormag_append_excluded_duplicate_posts() #2 /home/***/public_html/wp-content/plugins/siteorigin-panels/inc/renderer.php(717): colormag_featured_posts_slider_widget->widget() #3 /home/***/public_html/wp-content/plugins/siteorigin-panels/inc/renderer.php(1059): SiteOrigin_Panels_Renderer->the_widget() #4 /home/***/public_html/wp-content/plugins/siteorigin-panels/inc/renderer.php(1024): SiteOrigin_Panels_Renderer->render_widget() #5 /home/***/public_html/wp-content/plugins/siteorigin-panels/inc/renderer.php(936): SiteOrigin_Panels_Renderer->render_cell() #6 /home/***/public_html/wp-content/plugins/siteorigin-panels/inc/renderer.php(491): SiteOrigin_Panels_Renderer->render_row() #7 /home/***/public_html/wp-content/plugins/siteorigin-panels/inc/admin.php(1095): SiteOrigin_Panels_Renderer->render() #8 /home/***/public_html/wp-content/plugins/siteorigin-panels/inc/admin.php(209): SiteOrigin_Panels_Admin->generate_panels_preview() #9 /home/***/public_html/wp-admin/includes/template.php(1395): SiteOrigin_Panels_Admin->render_meta_boxes() #10 /home/***/public_html/wp-admin/edit-form-advanced.php(711): do_meta_boxes() #11 /home/***/public_html/wp-admin/post.php(206): require('/home/***/...') #12 {main} thrown in /home/***/public_html/wp-content/themes/colormag-pro/inc/template-tags.php on line 167

This appears to be due to the $colormag_duplicate_posts not being detected correctly. Likely due to the global not being able to be passed down the chain. Storing it using query var (or something like that) may account for not only this issue but any similar type of usage. Due to how this issue could be fixed in a few different ways I haven't come up with a fix. I would be happy to come up with one and submit it to any repo, or for someone else to submit it on my behalf.