thekarladam / mpoauth Goto Github PK

I just compiled the library with new Apple's LLVM Clang 4.0 which complains (shows a warning) in -[MPOAuthCredentialConcreteStore signingKey] method:

/MPOAuth/MPOAuthCredentialConcreteStore.m:183:41: warning: invalid conversion specifier '&' [-Wformat-invalid-specifier]
    return [NSString stringWithFormat:@"%@%&%@", consumerSecret, tokenSecret];
                                          ~^
/MPOAuth/MPOAuthCredentialConcreteStore.m:183:43: warning: more '%' conversions than data arguments [-Wformat]
    return [NSString stringWithFormat:@"%@%&%@", consumerSecret, tokenSecret];

Its result string should be simply: return [NSString stringWithFormat:@"%@&%@", ...]. The & character does not need any kind of escaping or special signs before it ;-)

Using the result of an assignment as a condition without parentheses

if (self = [super init])
if (self = [super initWithRequest:urlRequest delegate:inDelegate])
if (self = [super initWithAPI:inAPI forURL:inURL withConfiguration:inConfig])

should be

if ((self = [super init]))
if ((self = [super initWithRequest:urlRequest delegate:inDelegate]))
if ((self = [super initWithAPI:inAPI forURL:inURL withConfiguration:inConfig]))

Cheers

I'm trying to run MPOAuthMobile, and the assertion in MPOAuthAuthenticationMethodXAuth, line 33, is telling me that a username is required.

I figured out where to specify the consumer key and secret, but I can't figure out where the username is set. Where is it set?

Thanks very much.

I'm hesitant to ask, just because I feel I must be overlooking something. But...

Is there any documentation? A README? Quick Start?

Thanks, and I apologize in advance if it's here and I just can't find it.

When I launch Twitter app sample, I got an EXC_BAD_INSTRUCTION on line:

NSAssert(username, @"XAuth requires a Username credential");

In file: MPOAuthAuthenticationMethodXAuth.m

Is this a bug? Something I did wrong?

Thank you!