The pcyl-cli from thegrumpys

Implement comment and label support

These features need to be incorporated into the startup file.

Add use of ioopt to control output

It appears that we get mismatches between the JS and PLI output because ioopt is not implemented. So we need to implement checking ioopt for output. We do not need to SET IOOPT, because 5 is just fine.

Create count.js

Add comment '|' parsing

Add type property to constant, design parameter and state variable arrays

Consider adding type: "string", "integer" and "float" to each constant, design parameter and state variable entry.

Investigate why nodejs doesn't allow piped stdin and stdout and stderr!

Create update.js

Add "oldvalue" property into design_parameters and state_variables as defined in design.js.
Write update code to store current values of design parameters and state variables into oldvalue for potential later use.
Invoke the update function in start.js.
Make corresponding changes in list.js so that old values appear in "BEFORE SEARCH" column.

Modify fix command to use regular expression

I am trying to have us use a standard pattern for command decode whereby we shift split_line into variables, then check the variables using a regular expression before doing a parseFloat. This also removes the use of 'isNaN'.

Convert constants, design_parameters, and state variables from object to array

Also change command in list.js to be an array

NaN in output after fix of DP and search

See last part of session output.

**********************************************
***  Welcome to PCyl Version 1.2
**********************************************
PCyl: fix radius 0.444
fix radius 0.444
RADIUS IS FIXED AT         0.4440   INCH
PCyl: search
search
SEARCH:    OBJ =          0.476569
RETURN ON:      OBJ =           0.002707
THE RESULT IS NOT FEASIBLE.
         YOU NEED TO DO A LITTLE MORE WORK ON THIS DESIGN.
         REFER TO THE DOCUMENTATION SECTION ON  "FEASIBILITY"  FOR SUGGESTIONS.
CONSTRAINT VIOLATIONS
                        VALUE        LEVEL     DIFFERENCE    PERCENT
PRESSURE        MAX    1552.8056    1500.0000     52.8056      3.5204  VIOLATED
FORCE           MIN     961.6851    1000.0000     38.3149      3.8315  VIOLATED
VALUE OF THE OBJECTIVE FUNCTION AT THIS POINT IS:              0.002707
PCyl: list both
list both
INDEPENDENT VARIABLES                                      CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
PRESSURE        =     1552.8056  LB/SQ-IN                             1500.0000
RADIUS          =        0.4440  INCH       FIXED          0.4440        0.4440
THICKNESS       =          -NaN  INCH                      0.0000        0.0500
DEPENDENT VARIABLES                                        CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
FORCE           =      961.6851  LBS.                   1000.0000              
STRESS          =          -NaN  PSI                                  3000.0000
PCyl:

Create PCyl specific contnt.js

Calculate the value of Pi and return. The Spring specific version of this function will be far more complex … including user interaction.

PL/I code behavior investigation

List levels does not display full set of constraint levels.
List dependent displays a value for area where reading the PL/I code and execution of the JS code suggests that it shouldn't.

Future version food for thought - does the wm.edu version of PATSH have any role ?

http://www.cs.wm.edu/~va/software/PatternSearch/

Create search.js, srch.js, and patsh.js

Also modify despak to expand parameter vector.

Move scaling denominator code from design.js to start.js ...

… and modify app.js to invoke start function after intro and before first command prompt.

Populate the full set of 17 command placeholders

Enhance list command

Deferred list INTERNAL sub-command

Create save.js

Provide more symmetric command parsing for sfwriter and sfreader functions

File name should be passed in argument list.

Break eqnset1 into just equation set function and start up variables (design.js) file

Delay to 0.2

In design.js change smax = smin to sv.smax = sv.smin

Remove PL/I comments associated with encryption from intro.js

Future version food for thought ... rename the START command to "Edit" or "Open"

In order to better communicate that the program can be thought of as an "editor" for design files, it might be desirable to rename the START command to "Edit" or "Open".

Change out.txt to actual_out.txt

Make the branch table in app.js look more like list.js

Provide comparable substring abbreviation (startsWith()) feature.

Recode sclden into JavaScript

Feedback on current state of list command implementation

The response to an empty command line seems to produce an extra prompt:
PCyl>
PCyl:
PCyl>
Perhaps this is part of a feature that echoes command input.
The state variable "area" is missing from some of the responses. For example:
list dep
DEPENDENT VARIABLES CONSTRAINT LEVELS
STATUS MIN MAX
force = 251.3274 LBS. 1000.0000
stress = 2500.0000 PSI 3000.0000
A list command followed by multiple (DPSV) names separated by a single space produces expected results. A list command followed by the same set of names separated by multiple blanks produces unexpected results.
For this case, the term in parens should be "outputs":
PCyl>list state
PCyl: list state
DEPENDENT VARIABLES (inputs)
force = 251.3274 LBS. 0.0000
area = 0.5027 SQ.-IN. 0.0000
stress = 2500.0000 PSI 0.0000
PCyl>
"list levels" does not produce a listing of constraint levels.
The first design parameter in the listing produced by "list design" has an extra blank space in the "BEFORE SEARCH" column.
PCyl>list design
PCyl: list design
INDEPENDENT VARIABLES (inputs) BEFORE SEARCH
pressure = 500.0000 LBS/SQ-IN 0.0000
radius = 0.4000 INCH 0.0000
thickness = 0.0400 INCH 0.0000
PCyl>

Add more commands to test input file for remaining commands

Get istanbul working with in.txt for code coverage

Got coverage working - woohoo!

Move system level initialization code out of design.js and into intro.js

Specifically the non-problem dependent, system initialization code.

Update test files (in.txt, expected_dos.txt, etc.)

Create fix.js and free.js commands

Implement 15 of 16 sub-commands of List command

Defer: INTERNAL sub-command; Defer: Pause procedure; Defer?: output to print file (checkpt)

Break out list command into its own js file

Handle prompts with synchronous readit function

I think we need to switch to readline-sync package to be able to handle these prompts.

Add support for return codes from Pattern Search (NCODE)

The information is valuable to the user
The output comparisons performed as part of testing will have one less point of difference.

Make PCyl intro match DOS

Do npm init for pcyl repository

That is: 'npm init'

Make app.js and executable script

Add #!/usr/bin/env node, and make it have execute permission. Also add "test": "./app.js < test/in.txt > test/out.txt" to package.json scripts to execute it. Add out.txt file to .gitignore.

Unexpected behavior of change command ... bug ?

The following listing illustrates the issue. Notes ...

The objective function value of the starting point has been validated by PL/I PCyl. This suggests that despak is working correctly for this case of fixed/free, etc.

It is expected that using the change command to reduce the minimum constraint on FORCE to zero results in an objective function of zero. However, after using the change command to restore the original constraint, the objective function value remains at zero. This aspect of the behavior is unexpected.

**********************************************
***  Welcome to PCyl Version 1.2
**********************************************
START:
  The START command is not yet fully implemented.
PCyl: list both
list both
INDEPENDENT VARIABLES                                      CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
PRESSURE        =      500.0000  LB/SQ-IN                             1500.0000
RADIUS          =        0.4000  INCH                      0.0000        0.5000
THICKNESS       =        0.0400  INCH                      0.0000        0.0500
DEPENDENT VARIABLES                                        CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
FORCE           =      251.3274  LBS.                   1000.0000              
STRESS          =     2500.0000  PSI                                  3000.0000
PCyl: list viol
list viol
CONSTRAINT VIOLATIONS
                        VALUE        LEVEL     DIFFERENCE    PERCENT
FORCE           MIN     251.3274    1000.0000    748.6726     74.8673  VIOLATED
VALUE OF THE OBJECTIVE FUNCTION AT THIS POINT IS:              0.560511
PCyl: change force min 0.0
change force min 0.0
FORCE  MINIMUM CHANGED TO 0.0     LBS.
PCyl: list both
list both
INDEPENDENT VARIABLES                                      CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
PRESSURE        =      500.0000  LB/SQ-IN                             1500.0000
RADIUS          =        0.4000  INCH                      0.0000        0.5000
THICKNESS       =        0.0400  INCH                      0.0000        0.0500
DEPENDENT VARIABLES                                        CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
FORCE           =      251.3274  LBS.                      0.0000              
STRESS          =     2500.0000  PSI                                  3000.0000
PCyl: list viol
list viol
NO CONSTRAINTS ARE VIOLATED
VALUE OF THE OBJECTIVE FUNCTION AT THIS POINT IS:              0.000000
PCyl: change force min 1000.
change force min 1000.
FORCE  MINIMUM CHANGED TO 1000.     LBS.
PCyl: list both
list both
INDEPENDENT VARIABLES                                      CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
PRESSURE        =      500.0000  LB/SQ-IN                             1500.0000
RADIUS          =        0.4000  INCH                      0.0000        0.5000
THICKNESS       =        0.0400  INCH                      0.0000        0.0500
DEPENDENT VARIABLES                                        CONSTRAINT LEVELS
                                            STATUS         MIN           MAX
FORCE           =      251.3274  LBS.                   1000.0000              
STRESS          =     2500.0000  PSI                                  3000.0000
PCyl: list viol
list viol
NO CONSTRAINTS ARE VIOLATED
VALUE OF THE OBJECTIVE FUNCTION AT THIS POINT IS:              0.000000
PCyl:

Change let-of to index loop and change push() to array access

For example, change from

for (let dp of design_parameters) {
    if (dp.lmin != FIXEDSTAT) {
        nfree++;
        pc.push(dp.value);
    }
}

to

var pc = [];
for (let i = 0; i < design_parameter.length; i++) {
    var dp = design_parameter[i];
    if (dp.lmin != FIXEDSTAT) {
        nfree++;
        pc[i] = dp.value;
    }
}

Make fix/free command match DOS output

Copy PLI source into unimplemented commands

Make all input/output uppercase to match DOS input/output

Create despak.js

Create change.js command

Add "use strict"; to all files

Add test input, in.txt, and test output, out.txt

These files allows you to run the program feeding it a series of commands, capturing the actual output, and then comparing it to the expected output.

node app.js < test/in.txt > test/actual_out.txt
diff -y -W 256 test/expected_out.txt test/actual_out.txt

This allows a quick check after making changes to verify the system is still operating as expected.

I suggest doing this at each release, and possibly more often. At each release the updated output should be checked in to replace the current test/expected_out.txt to incorporate the updates and prepare for the following release.

Change command acknowledgement wrong for constraint levels

It appears that the problem is only in the acknowledgement; not in the value that is set for constraint levels.

The may be a good time to confirm that parseFloat() is also applied to constants and any other appropriate places in the change.js module.

**********************************************
***  Welcome to PCyl Version 1.2
**********************************************
PCyl: change thick max 0.155
change thick max 0.155
THICKNESS MAXIMUM CHANGED TO         0.0000   INCH
PCyl: change stress max 7000.1
change stress max 7000.1
STRESS MAXIMUM CHANGED TO         0.0000   PSI
PCyl: 
PCyl: list thick

list thick
THICKNESS       =        0.0400  INCH                      0.0000        0.1550
PCyl: list stress
list stress
STRESS          =     2500.0000  PSI                                  7000.1000
PCyl:

Enhance start command

Deferred read of startup file.

thegrumpys / pcyl-cli Goto Github PK

pcyl-cli's People

Contributors

Watchers

pcyl-cli's Issues

Recommend Projects

Recommend Topics

Recommend Org