thegraydot / barcomic_server Goto Github PK

The interactive input is a little messy. Command line arguments should be used, and defaults used if not provided by the user.

https://pkg.go.dev/flag

• a, addr
• p, port

The program should print the config when running so users know. This could be under the QR code.

Put in a check to validate input from app/client. Should be under a certain size (barcode length) and only numbers.

For UPC validation:

https://github.com/nicholassm/go-ean/blob/master/ean.go

For digit check:

https://programming-idioms.org/idiom/137/check-if-string-contains-only-digits/1739/go

Could also:

• limit request body size
• check bytes of body before string conversion

Couple problems with keybd package

• can't cross compile for os x on Linux
• need sudo on Linux

Research and test other solutions

https://github.com/go-vgo/robotgo

Should return status 200 OK if up

When the barcode is executed into key strokes, there is an additional character. The last digit is being repeated. Could be how the buffer is converted to a string.

• put in makefile
• figure out how to put in git tags
• try auto update golang version in go.mod

This makes sense, don't need the performance of sockets and could use mock tests, better ssl, auth options? And ease of use of http.

iOS doesn't support self signed certs, and Android needs a hacky fix. This means it should probably be non-default to enable https. When a managed server is implemented, https will be done on domain name, so self signed https is not needed.

Todo:

• k argument should enable self signed https, and should be default to off

• Install go
• Install linux dependencies
• Install go packages
• Compile

• version
• build status

Should be able to just enter and accept default - however, no selection is crashing:

[*] barcomic dev-mode
[*] The following addresses are available...
    [0] 10.10.10.1 (wlp3s1)
    [1] 10.10.10.1 (br-adb8080eff94)
    [2] 10.10.10.1 (br-3ed7272d5345)
    [3] 10.10.10.1 (docker0)
[*] Enter IP address [0.0.0.0]: 

[*] Error. Could not determine network interface selection.
exit status 1

Socket networking provides some benefits for integration with the Android app. Makes sense to add it back in, with a CLI argument.

Probably not really necessary, but strong TLS would be nice to have

If an ip isn't provided, it means an end user cannot scan the qr code and connect.

Should handle:

• Ability to build binary with version
• Potential to auto increment

Add support for selecting the number of the interface to save the user from typing out the address

https://www.kencochrane.com/2020/08/01/build-and-sign-golang-binaries-for-macos-with-github-actions/

Feature should determine what network interface and port (get programmically, or from user), the print qr code to the terminal

Log name same as binary (with date)
Use .log extension

https://pkg.go.dev/log

Also add to GitHub README
Then add to Actions pipeline

This should work with scripts, tags and GitHub actions

Initially configure to:

• Test on main/PR
• Build and release on tagged

https://github.com/actions/setup-go

https://stackoverflow.com/questions/66918575/how-to-use-your-own-makefile-in-github-actions

https://github.com/marketplace/actions/go-release-binaries

Since this takes 2 seconds on Linux, create the object once, then use Clear function for subsequent barcodes.

https://github.com/micmonay/keybd_event/blob/f60812ed9d3ad42cabdecf124bb4538adcbd247f/keybd_event.go#L28

If not run as specific user, warn and elevate. Or maybe find solution to chown and add to group for key events

Internal server should be called barcomic_server for consistency
Also update go.mod file to reflect changes

• Docker compose
• Nginx -> golang

https://pkg.go.dev/tailscale.com/net/interfaces

• print list of interfaces
• select one to listen on
• add test