theeddychang / alldaynba Goto Github PK

Project Strengths

• Creative problem solving by accessing NBA data via their in-house API. And nice job on not getting shut down in the process. 🏀
• Great use of a rake task to run dynamic API queries based on the day and store that data into your database.
• Excellent work on the calculate_probability! method. It's fairly impressive to dive into your own data analysis of any kind.
• Nice use of scope to pull todays_games from the database!

Growth Opportunities

• Project Planning: Next time you're working on a project, make sure to plan out details beforehand, like which API data you need and how you'll define your database relationships. It helps to start with clear, precise user stories that define the value proposition, and wireframes that depict how users will interact with your site.
• Naming Conventions: Your naming is all over the place. You can't control the format of API params or data, but ALWAYS use snake_case in Rails for any variable names, method definitions, etc. that you have control over.
• Primary/Foreign Keys: You're using the "NBA ids" as primary and foreign keys, and that can be really confusing to other developers. Stick to the Active Record ids unless you have a compelling reason to do otherwise.
• Routes & Controller Methods:
  • These do the same thing - pick one.
  • This controller method doesn't exist.
  • games#show isn't very RESTful, since it appears to be an alternate view for @allGames. The show action should always relate to a single instance of any given resource.
  • Remove any controller methods you're not using.
• Views: The random spacing in the views is very confusing, and it makes the code hard to follow.
• Testing: You have an excellent method on the Game model for calculating probability, and it deserves a test. 😄
• To Get Ready for Deploy:
  • README: Add a README file explaining a little about your project, the technologies you used, and how another developer could run the project locally. Follow the Project 3 Guidelines.
  • Gem Groups: The bootstrap-sass gem is in the development group. Make sure to move it out, so the gem can work in production.
  • Postgres Database: Change your database from SQLite to Postgres. You can follow this Heroku guide.
  • Schedule Rake Task: You'll need to schedule your todays_games_info rake task to run every day on Heroku. Read about the Heroku Scheduler.
• User Interactivity: You did an awesome job sorting through API data and displaying it in a meaningful way. The main thing I see that's missing from this app is an element of user interactivity. Push yourself to dive deeper into Rails by implementing users. Sign up / log in could be optional, but maybe it unlocks additional features, like "watching" specific games or the ability for users to make their own win predictions.