Comments (17)
i need some feed back i am i going in the right tracks
from thecyberhub.
can I work on it ?
from thecyberhub.
ok .should i create a pull request ?
from thecyberhub.
i think this implementation is much better than just throwing the + sign in the input field
it's more orgenized and clear like this plus it has a hover effect to indicatee the clickable button
from thecyberhub.
It's great having you contribute to this project
🌟 Welcome to the community 🌟
- If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
- You should join our Discord chat and our GitHub Organisation.
- We help and encourage each other to contribute to open source little and often 😄.
- Any questions let us know.
from thecyberhub.
@firassssss seems very needed, do you want to handle it?
from thecyberhub.
@firassssss is it ok that he/she will work on it?
from thecyberhub.
@ArkadiK94 yes i am ok with it
from thecyberhub.
@Salem-Bourguiba yes, you can work on it
from thecyberhub.
@Salem-Bourguiba Looks awesome 😎
from thecyberhub.
should i add a plus sign in the end of the input bar ? or add a goal placement is fine ?
from thecyberhub.
@Salem-Bourguiba we have "add goal" button so I think it is enough but if you have a different proposal that you think will look better we can discuss
from thecyberhub.
from thecyberhub.
@Salem-Bourguiba The "add goal" button is more intuitive in my opinion.
@firassssss What do you think?
@kabir0x23 What do you think?
from thecyberhub.
@Salem-Bourguiba The "add goal" button is more intuitive in my opinion. @firassssss What do you think? @kabir0x23 What do you think?
i think i serves its purpose better than "add a goal" , think he should keep the + sign
from thecyberhub.
@Salem-Bourguiba I am ok with the '+' sign so place it outside of the input box at least
from thecyberhub.
@Salem-Bourguiba Yes, you don't need to ask when to create a pull request, you should do it when you feel that the code is ready for review.
Unless, you want to ask something particular about the code or show progress so you can create draft pr, fyi :)
from thecyberhub.
Related Issues (20)
- [BUG] Edit Profile navigating to 404 not found page HOT 2
- Interface Freezes when trying to create an empty feed. HOT 2
- [FEATURE] Add an Incident Notification System. HOT 4
- [Style] BinExploit | filtering a keyword in BinExploit HOT 5
- [FEATURE] Analytics | Add Functionality For Download Button HOT 8
- [Bug] Glitch in Navigation Bar in Brave Browser HOT 5
- [Responsive-Web] Search/Sidebar width not full in small screen HOT 4
- [Responsive-Web] Irresponsive Elements on mobile screen HOT 2
- [Responsive-Web] Chat sidebar auto-hiding is not in working in small screen HOT 2
- [Responsive-Web] AI new chat section is not responsive HOT 15
- [FETURE] Popup Registration Window for Unregistered Users Submitting Blog Comments HOT 2
- [FEATURE] Search Functionality in Chatbox HOT 1
- [BUG] Cursor position error in Notes section HOT 1
- [BUG] Font Color error in Goals section on dashboard HOT 2
- [FEATURE] Dashboard | Add copy button to encoded fields HOT 4
- [BUG] encoder | hover color covers the text HOT 3
- [FEATURE] Add storybook HOT 7
- [BUG] Facebook community social link briken HOT 5
- [BUG] navbar | tabs are transparent HOT 1
- [FEATURE] Add storybook for GeneralDashboardSidebar HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thecyberhub.