Coder Social home page Coder Social logo

Comments (17)

Salem-Bourguiba avatar Salem-Bourguiba commented on June 7, 2024 3

i need some feed back i am i going in the right tracks
Capture d'écran 2024-04-27 005315

from thecyberhub.

Salem-Bourguiba avatar Salem-Bourguiba commented on June 7, 2024 1

can I work on it ?

from thecyberhub.

Salem-Bourguiba avatar Salem-Bourguiba commented on June 7, 2024 1

ok .should i create a pull request ?

from thecyberhub.

Salem-Bourguiba avatar Salem-Bourguiba commented on June 7, 2024 1

Capture d'écran 2024-04-27 135845
i think this implementation is much better than just throwing the + sign in the input field
it's more orgenized and clear like this plus it has a hover effect to indicatee the clickable button

from thecyberhub.

github-actions avatar github-actions commented on June 7, 2024

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@firassssss seems very needed, do you want to handle it?

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@firassssss is it ok that he/she will work on it?

from thecyberhub.

firassssss avatar firassssss commented on June 7, 2024

@ArkadiK94 yes i am ok with it

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@Salem-Bourguiba yes, you can work on it

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@Salem-Bourguiba Looks awesome 😎

from thecyberhub.

Salem-Bourguiba avatar Salem-Bourguiba commented on June 7, 2024

should i add a plus sign in the end of the input bar ? or add a goal placement is fine ?

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@Salem-Bourguiba we have "add goal" button so I think it is enough but if you have a different proposal that you think will look better we can discuss

from thecyberhub.

Salem-Bourguiba avatar Salem-Bourguiba commented on June 7, 2024

Capture d'écran 2024-04-27 131332
like this maybe ?

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@Salem-Bourguiba The "add goal" button is more intuitive in my opinion.
@firassssss What do you think?
@kabir0x23 What do you think?

from thecyberhub.

firassssss avatar firassssss commented on June 7, 2024

@Salem-Bourguiba The "add goal" button is more intuitive in my opinion. @firassssss What do you think? @kabir0x23 What do you think?

i think i serves its purpose better than "add a goal" , think he should keep the + sign

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@Salem-Bourguiba I am ok with the '+' sign so place it outside of the input box at least

from thecyberhub.

ArkadiK94 avatar ArkadiK94 commented on June 7, 2024

@Salem-Bourguiba Yes, you don't need to ask when to create a pull request, you should do it when you feel that the code is ready for review.
Unless, you want to ask something particular about the code or show progress so you can create draft pr, fyi :)

from thecyberhub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.