thecodemonks / nytimes-app Goto Github PK
View Code? Open in Web Editor NEW๐ฝ A Simple Demonstration of the New York Times App ๐ฑ using Jsoup web crawler with MVVM Architecture ๐ฅ
License: MIT License
๐ฝ A Simple Demonstration of the New York Times App ๐ฑ using Jsoup web crawler with MVVM Architecture ๐ฅ
License: MIT License
We can add Ktlint support and Format for housekeeping in the project, it will get for common lint errors and do code formatting on PR and Merge
App open with no internet message
App crashes immediately
Steps to reproduce :
Expected : App should navigate to article details.
Fix :
Bookmark seems to have wrong navigation path
newsAdapter.setOnItemClickListener { article ->
...
findNavController().navigate(
R.id.action_articlesFragment_to_articleDetailsFragment,
bundle
)
}
It should be ,
newsAdapter.setOnItemClickListener { article ->
val bundle = Bundle().apply {
putSerializable("article", article)
}
findNavController().navigate(
R.id.action_bookmarksFragment_to_articleDetailsFragment,
bundle
)
}
Add extension function to remove boilerplate code
Great work on the app! One change I was thinking about, was using a theme engine like Cyanea I've used it in a past app of mine and is easy to implement and I think would give NYTimes-App great character
Refactor Code on Network Connectivity & Add Base Fragment
Hi @Spikeysanju you can introduce DI in this project
if you don't want to deal with Dagger, you can do manual DI using only Kotlin,
you can see my approach from below post
https://proandroiddev.com/hold-on-before-you-dagger-or-hilt-try-this-simple-di-f674c83ebeec
When ever we switch tabs the list first shows the previous data then flicker to a new list
on switch tabs no flickering should appear
Datastore
Hacktoberfest 2020
for the this eventsDatastore
- https://developer.android.com/topic/libraries/architecture/datastore
@Spikeysanju Hi i will be cool to have test cases, can you create a mile store and we can estimate Testing in the project?
Replace Application Component(Deprecated) with Singleton Component
share article URL from article details page using ShareSheet
@Spikeysanju
StateFlow
Hacktoberfest
for the this eventsโ ๏ธ Note - Fade in & fade out collapse needs to be done!
StateFlow
- https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.flow/-state-flow/
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.