thecherno / chernocraft

A small Minecraft clone in C++.

ChernoCraft

A small Minecraft clone in C++.

chernocraft's Issues

Hi!

How to run it?

Memory

Hello,
In the graphics/screen.cpp aren't we supposed to allocate the memory of the title, because it is char* we need to set it dynamically.

Not deleting fragment shader if vertex shader fails to load

GLuint Shader::load(const char *vs, const char *fs) {
    GLuint program = glCreateProgram();
    
    GLuint vert = glCreateShader(GL_VERTEX_SHADER);
    GLuint frag = glCreateShader(GL_FRAGMENT_SHADER);
    
    glShaderSource(vert, 1, &vs, NULL);
    glCompileShader(vert);
    
    GLint result;
    glGetShaderiv(vert, GL_COMPILE_STATUS, &result);
    if (result == GL_FALSE) {
        / *rest of function*/
        glDeleteShader(vert);
        throw new std::runtime_error("Could not compile vertex shader!");
    }
    /*rest of function*/
}

I believe the shader for frag will not be cleaned up due to the throw