Coder Social home page Coder Social logo

Comments (8)

lakhansamani avatar lakhansamani commented on May 30, 2024

@thebigredgeek Is there any repo or branch where this work is started?

from apollo-errors.

thebigredgeek avatar thebigredgeek commented on May 30, 2024

Not yet, nope! But I am looking for help with it if you wanna get started?

from apollo-errors.

lakhansamani avatar lakhansamani commented on May 30, 2024

Sure, would love to do that

from apollo-errors.

thebigredgeek avatar thebigredgeek commented on May 30, 2024

Awesome! I look forward to your PR :D

from apollo-errors.

lakhansamani avatar lakhansamani commented on May 30, 2024

Hey @thebigredgeek I have tried making typescript version, you can check here https://github.com/lakhansamani/apollo-errors/tree/typescript

Please share your feedback on this and on how we want to build and publish it

from apollo-errors.

thebigredgeek avatar thebigredgeek commented on May 30, 2024

@lakhansamani it looks good so far! Are we able to get the existing tests passing?

Also, it might be a good idea to add types the createError config property etc. Basically anything that is in interface between components and to the outside world.

We also need to create a PR at definitively-typed

from apollo-errors.

lakhansamani avatar lakhansamani commented on May 30, 2024

@thebigredgeek test cases are passing so far

Can you explain how you want to add types, that part was not clear

from apollo-errors.

thebigredgeek avatar thebigredgeek commented on May 30, 2024

Right, so there is an interface for the ApolloError constructor as well as the createError function. We should have a typed interface for these, and create an entry for DefinitelyTyped so that people can install the type definitions

from apollo-errors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.