Coder Social home page Coder Social logo

Comments (18)

thebigredgeek avatar thebigredgeek commented on May 30, 2024 8

Thanks! I'll try to submit a fix for this later tonight

from apollo-errors.

groundmuffin avatar groundmuffin commented on May 30, 2024 4

i actually lost sleep because of this issue :)

from apollo-errors.

groundmuffin avatar groundmuffin commented on May 30, 2024 3

Please, fix this )

from apollo-errors.

lobodart avatar lobodart commented on May 30, 2024 3

Any update on this? I had to downgrade to 1.5.1 😞

from apollo-errors.

Ponjimon avatar Ponjimon commented on May 30, 2024 1

Somehow this only happens if I run it in production mode, locally it works?

from apollo-errors.

thebigredgeek avatar thebigredgeek commented on May 30, 2024 1

A fix for this should be live in 1.8.0. Can anyone here confirm?

from apollo-errors.

azterix avatar azterix commented on May 30, 2024

I am seeing the same thing. I don't know enough about the history and/or reasoning to use arguments[2] in the ApolloError constructor (instead of using the config variable) to put in a PR for it, but there are only 2 args in the arguments array when I through and the relevant data is in config / arguments[1].

I haven't tried v 1.5.1 myself, but by tweaking that argument reference it works as expected for me.

from apollo-errors.

Connorelsea avatar Connorelsea commented on May 30, 2024

I am attempting to throw an error inside of a resolver by doing throwing an error created using apollo-errors

const UserDoesntExistError = createError("UserDoesntExist", {
  message: "A user with this email address does not exist",
})
...
if (!user) throw new UserDoesntExistError()

On the frontend when this error occurs, the message is not displayed.

image

from apollo-errors.

joshmanders avatar joshmanders commented on May 30, 2024

bump

from apollo-errors.

dakshshah96 avatar dakshshah96 commented on May 30, 2024

Any updates on this?

from apollo-errors.

luisgrases avatar luisgrases commented on May 30, 2024

just created a simple pull request: #32

from apollo-errors.

luisgrases avatar luisgrases commented on May 30, 2024

My pull request still doesn't fix all issues so it is better to just use 1.5.1

from apollo-errors.

ecwyne avatar ecwyne commented on May 30, 2024

#29 should also fix this issue

from apollo-errors.

joshmanders avatar joshmanders commented on May 30, 2024

@thebigredgeek confirmed it works.

from apollo-errors.

ash0080 avatar ash0080 commented on May 30, 2024

@thebigredgeek missing again in 1.9 plz reopen it

from apollo-errors.

thebigredgeek avatar thebigredgeek commented on May 30, 2024

@theGlenn I thought we had a test case for this. confused haha

from apollo-errors.

pcorey avatar pcorey commented on May 30, 2024

I'm also facing this issue. It only seems to happen in production for me. Locally everything works fine.

from apollo-errors.

thebigredgeek avatar thebigredgeek commented on May 30, 2024

@theGlenn did you have a chance to test for this?

from apollo-errors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.