the-fireplace-minecraft-mods / clans Goto Github PK

Currently, the item does not show in the inventory because the client hasn't been told it's still there. This needs to be fixed.

This can be done in a number of ways. First of all, a /playerdetails command could be used to provide info about if a player is online, what clans the player is in, and what rank the player is in those clans. Secondly, the default clan could be shown before the player's name in the chat.

This should include:

• Clan description shows when you enter clan territory
• View all players in clan details, not just online
• See player info: What clans they are in
• Ability to list all clans on a server

There should be sort options for /clan list. It needs to sort alphabetically by default, and be able to take an additional parameter to sort by land, money, or members.

When a raid begins, and the rocket arrives from the neutral zone or the zone belonging to another fraction and hits the attacked zone, the destruction of the blocks does not occur.

When a player is in another dimension and uses /clan home to teleport to the overworld(or i guess wherever the clan is located) a server crash occurs.

java.lang.NullPointerException: Exception in server tick loop
	at net.minecraft.world.Teleporter.func_180620_b(Teleporter.java:134)
	at com.therandomlabs.randompatches.common.RPTeleporter.func_180620_b(RPTeleporter.java:46)
	at net.minecraft.world.Teleporter.func_180266_a(Teleporter.java:34)
	at com.therandomlabs.randompatches.common.RPTeleporter.func_180266_a(RPTeleporter.java:37)
	at net.minecraft.world.Teleporter.placeEntity(Teleporter.java:436)
	at com.therandomlabs.randompatches.common.RPTeleporter.placeEntity(RPTeleporter.java:73)
	at net.minecraft.server.management.PlayerList.transferEntityToWorld(PlayerList.java:721)
	at net.minecraft.server.management.PlayerList.transferPlayerToDimension(PlayerList.java:624)
	at net.minecraft.entity.player.EntityPlayerMP.changeDimension(EntityPlayerMP.java:695)
	at net.minecraft.entity.Entity.func_184204_a(Entity.java:2543)
	at the_fireplace.clans.commands.teleportation.CommandHome.teleportHome(CommandHome.java:71)
	at the_fireplace.clans.event.Timer.onServerTick(Timer.java:62)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_473_Timer_onServerTick_ServerTickEvent.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
	at net.minecraftforge.fml.common.FMLCommonHandler.onPostServerTick(FMLCommonHandler.java:266)
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:712)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
	at java.lang.Thread.run(Thread.java:748)

This seems to only occur when the player has left his/her clan for 5 minutes, or when the chunks have unloaded. The crash report mentions the mod "random labs" however i haven't found any mention of a problem like this on their side

Clans-1.12.2-1.2.4
GrandEconomy-1.12.2-1.0.1

Forge version :1.12.2-14.23.5.2781

Great to be able to remove the clan home command.

When I'm a leader of my own clan I can invite myself.

This is fine, however if i was to accept the clan invite it will 'invite' me and thus demote my leader rank to a normal rank.

I tested this both as an opped player and a regular player

Using clans 1.2.2 on mc version 1.12.2

Forge version :1.12.2-14.23.5.2781

Ideally, these built in colors would just be the same as the minecraft chat colors.

Thank you for reporting!

For issues:

• Try the latest version, it may have fixed the issue already.
• Provide the Forge version you experienced the issue with. Do not say "latest" for this, provide the actual version number.
• Provide the mod version you experienced the issue with. Do not say "latest" for this, provide the actual version number.
• For any issue, providing your client and/or server logs can be helpful in geting the issue solved quickly. These are usually named something like latest.log, debug.log, fml-client-latest.log, or fml-server-latest.log and can be found in the logs folder. If you have one of these, please paste it to Ubuntu Pastebin or Pastebin and link it here. If you have latest.log and debug.log, please provide both.
• If you crashed, please paste the crash log to Ubuntu Pastebin or Pastebin and link it here.

The Exu mechanical user will not work inside of a claimed area. I am on version Clans-1.12.2-1.1.5.jar of the mod.

As of right now, the charge is applied when the raiding party is formed. However, this is bad for several reasons:

1. If the server goes down or the enemy clan members log off before starting the raid, that's money wasted.
2. Anyone could join the raiding party then do /raid start, without anything preventing them from doing so. This change would put the cost of starting the raid onto whoever uses the /raid start command, thus deterring people from randomly starting the raid.

Storage Drawers are accessible inside of a clan claimed area. You can left click the drawer and get items. I am on version Clans-1.12.2-1.1.5.jar of the mod.

https://pastebin.com/WBjaB8Ps

http://prntscr.com/nbkje1

I have an initial balance. When i form a clan it deducts the set amount of credits (i looked through the source and im confident that works accordingly)

I:formClanBankAmount=5000

# Cost of forming a clan. This requires a compatible economy to be installed.
# Min: 0
# Max: 2147483647
I:formClanCost=100`

However when the clan is formed i seem to get an extra $175?

This is my config setting for GrandEconomy
# Amount of credits given to new players joining the server [range: 0 ~ 10000, default: 100] I:startBalance=200

So i did a bit of digging. It seems on the New clan creation/construction it creates a new Grandeconomy account?

Clans.getPaymentHandler().ensureAccountExists(clanId);

public void ensureAccountExists(UUID account) {
		Account.get(account);
	}

To which it then adds the config amount to this new GrandEconomy account;

Clans.getPaymentHandler().addAmount(Clans.cfg.formClanBankAmount, clanId);

So in theory its an extra $200. However i instead end up with an extra $175 so i don't know whats happening to deduct $25.

Anyway to sum up, i get an extra $175 on clan creation on top of formClanBankAmoun

Clans-1.12.2-1.2.3
GrandEconomy-1.12.2-1.0.1

Forge version :1.12.2-14.23.5.2781

Edit: Also side note, with /clan details giving details of clan, what was the decision of having the clan balance not being displayed on the details?

Currently, all strings are hardcoded. Move them to localization files so they can be translated.

This should be a config option that forces clans to have connected claims. This prevents clans from having one faraway claim with one player sitting on it running the raid timer out.

Because of this, the map's chunks don't line up. Find out which characters have a matching width in both Minecraft Font and Minecraft Unicode Font, and use only those.

One thing that really sucks about servers is people claiming a town. It basically defeats the purpose of an rpg server. If your mod could auto claim the chunks around the per-generated village that would be sweet! Note it would be awesome if it would only claim none player created structures blocks so that way people could still mine underneath cities but Eh.

Clans 1.2.3
MC 1.12.2

Make this so it's disabled until the op uses a command such as /oc claimadmin or something to toggle it.

https://pastebin.com/b1t11KgK

In 1.2.2, they are not supposed to fall at all as a temporary duping fix. However, they should really be allowed to fall and tracked.

Clearly this doesn't work too well since players are reporting errors such as it randomly thinking they are not in a clan. Solution: Switch to UUID based caching. ClanCache methods can still accept EntityPlayerMP and use the player's UUID for the check.

Thank you for reporting!

For issues:

• Try the latest version, it may have fixed the issue already.
• Provide the Forge version you experienced the issue with. Do not say "latest" for this, provide the actual version number.
• Provide the mod version you experienced the issue with. Do not say "latest" for this, provide the actual version number.
• For any issue, providing your client and/or server logs can be helpful in geting the issue solved quickly. These are usually named something like latest.log, debug.log, fml-client-latest.log, or fml-server-latest.log and can be found in the logs folder. If you have one of these, please paste it to Ubuntu Pastebin or Pastebin and link it here. If you have latest.log and debug.log, please provide both.
• If you crashed, please paste the crash log to Ubuntu Pastebin or Pastebin and link it here.

This makes it so defenders can't hide out underground to run the raid timer out. Config option for the number of minutes.

This would have a config to enable/disable it, and just ensures an edge of wilderness around each clan's claims that only that clan can claim.

The Plant Sower and Plant Gatherer from Industrial Foregoing are not able to function with claimed chunks. I am using version Clans-1.12.2-1.1.5.jar.

Something like /clan trapped to teleport them out of the clan territory they are trapped in

Version: Clans 1.2.3

Mekanism Mod have 1 Ítems, Digital Miner. This object is capable of mining automatically. But it can not be used by its owners, in their own areas.

According to some users on Discord, the clan command permissions are lost when you die, and you must relog to regain permission. My guess is that it's a capability related issue, needs further investigation.

When inviting someone to the clan, you are the recipient of the invite message in chat, rather than the person being invited who is instead left unnotified. They can still accept the invite if they blindly type the "/accept" command.

This would add several new commands:
/clan lock|l [private|clan|open] - private(default): makes a chest private to the player who locked it, clan: prevents anyone from locking the chest, leaving it accessible to the whole clan, open: prevents anyone from locking the chest, and grants access to players who are not in the clan
/clan lockchunk|lc [private|clan|open] - same as above but for all containers in the chunk
/clan unlock|ul - removes the lock from a claimed chest. Clan leaders can use this to unlock any chest in their clan.
/clan grantaccess|ga - gives the specified player access to your locked chest. Does not have to be a clan member, but if they are then get removed, they should get removed from the container.
/clan takeaccess|ta - removes a player's access from the container

In addition to all of this, the locks on chests should go away when the clan is disbanded. Users' locked chests unlock when they leave or are kicked from the clan.

This would make updating it to add new information easier, and allow server owners to directly modify clans. Keep the legacy file there and make sure it can deserialize old databases and export them into the new json format.

For colors, perhaps Red for other clans' territory, Green for your clans' territory, Yellow for wilderness, and Blue for the player's position.

I am on version Clans-1.12.2-1.1.5.jar of the mod. We have the following crash.

https://pastebin.com/awWmRKeY

It would be great to have the ability to set the max claimed chunks per clan member.

As someone on CF suggested, minimap integration for claimed land would be a plus. This would likely require Clans to be loaded on the client side to do the integration, but this client presence could be used for more aesthetic improvements and features in the future. It would be an optional client presence too, so if Clans is not loaded on the client, no harm done, the mod still works as intended.

Thank you for reporting! Please provide the information requested below in this post and delete this template. There is no need to make a separate comment with the below details if you put them into this post.

For issues:

• Try the latest version, it may have fixed the issue already.
• Provide the Forge version you experienced the issue with. Do not say "latest" for this, provide the actual version number.
• Provide the mod version you experienced the issue with. Do not say "latest" for this, provide the actual version number.
• For any issue, providing your client and/or server logs can be helpful in geting the issue solved quickly. These are usually named something like latest.log, debug.log, fml-client-latest.log, or fml-server-latest.log and can be found in the logs folder. If you have one of these, please paste it to Ubuntu Pastebin or Pastebin and link it here. If you have latest.log and debug.log, please provide both.
• If you crashed, please paste the crash log to Ubuntu Pastebin or Pastebin and link it here.

Clan members should be able to be issued private plots within their clan that only they can modify. Pricing should come in the form of either increased rent for that player or a separate private plot fee.

Make it so each clan subcommand has an associated permission in Sponge

Add a "buffer" period of time between /raid start and the start of the raid. This gives the defenders a chance to prepare to defend themselves. This period of time should be a config option set to 90 seconds by default.

Weird bug where as soon as I leave my claimed chunks, be it directly into another claim or into the wilderness, I stop doing damage to hostile and friendly mobs.

I can hit them, the animation plays and the sound effects do too, but I could stand there and swing for 15 minutes at a single mob.

When a mob farm is in use all mobs are immune to damage from all modded mob killing blocks(Extra utilities: spikes, Extra utilities:mechanical user, Draconic Evolution: Mob Grinder...e.t.c)

In more detail, mobs get hit and a sound effect occurs however there is no health reduction from targeted mob.

In regards to buildadmins: All mobs ignore any interaction with a buildadmin/opped player.

Clans-1.12.2-1.2.4
GrandEconomy-1.12.2-1.0.1

Forge version :1.12.2-14.23.5.2781

Forge | 1.12.2 | 14.23.5.2836
Clans | 1.12.2 | 1.2.3

As title says, when using a block placer from "Industrial Foregoing" on a claimed land it resulted in an instant crash, aswell as instant crash on re-entering the server.

https://pastebin.com/68zRVmrL

Allow OPs to promote, demote, or kick other clans' members, disband other clans, and edit other clans' names and descriptions.

Since clans don't exactly form alliances or go to war with each other, there is no reason not to allow players to join multiple clans. Leave a config option in so servers can disable this feature if they wish.