Coder Social home page Coder Social logo

Comments (4)

github-actions avatar github-actions commented on June 13, 2024

We found the following entry in the FAQ which you may find helpful:

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

from textual.

willmcgugan avatar willmcgugan commented on June 13, 2024

This is the expected behaviour, given the DataTable is larger than its container and the container doesn't scroll.

Having a table of height 100% caused a lot of confusion with auto height containers. Because the container is saying "I'll be as tall as the children" and the child is saying "Ill be as high as my parent.". Setting the default height to "100vh" fixes that, but it does mean that it may not fit inside a single screen.

It's simple enough to set the height to 100% or 1fr though.

from textual.

TomJGooding avatar TomJGooding commented on June 13, 2024

Wasn't this issue with auto sized containers addressed in a later PR?

If I change the CSS in the example to the below, I don't see the issue you're describing on v0.52.1?

    CSS = """
    Horizontal {
        border: solid red;
        height: auto;
    }

    DataTable {
        border: solid pink;
        max-height: 100%;
    }
    """

from textual.

TomJGooding avatar TomJGooding commented on June 13, 2024

After looking back through the issues and PRs, it looks like this issue #2975 was fixed in #3814.

Would you consider a PR to change the default max-height of the DataTable back to 100%?

from textual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.