Input and TextArea have cursor blinking even though terminal window is not focused about textual

[willmcgugan]

We should implement these ANSI codes. Should be straightforward in theory. Enable the escape sequences, and convert them to AppFocus and AppBlur.

Talk to @willmcgugan if more clarification is needed.

[davep]

With an eye on the motivation for this: it would seem that there's benefit to the widgets in the focus chain knowing when AppFocus and AppBlur happens; I wonder if perhaps those events should be posted to the focused widget and allowed to bubble?

[willmcgugan]

What is the benefit?

[davep]

Just thinking about if there's utility for it when it comes to a random developer wanting to implement functionality on a widget that's related to having focus or not, and wanting to take into account if there emulator window has focus (while I recognise that it's not done with Focus and Blur with Input and TextArea, I'm thinking about any situations we've not considered yet that might be akin to the original motivation for the question that resulted in this issue).

[willmcgugan]

The behaviour (in Textual-web) is that when the window loses focus, the focused widget is blurred. When the window regains focus, the previously blurred widget is focused again.

This feels like an extension of the regular focus mechanism. I can't think why a developer would want to do something different. You can always check if the windows as focus with self.app.app_focus.

[davep]

The behaviour (in Textual-web) is that when the window loses focus, the focused widget is blurred. When the window regains focus, the previously blurred widget is focused again.

Ahh, cool, so it seems this is already taken care of anyway? Nice.

[davep]

Something to consider, perhaps as part of this, or as a fresh issue: it seems that the current implementation of AppBlur and AppFocus, as seen in textual-web, causes focus to be fully lost. For example, while testing with this code:

from pathlib import Path
from textual.app import App, ComposeResult
from textual.widgets import Digits, Input, TextArea

class AppFocusBlurApp(App[None]):

    def compose(self) -> ComposeResult:
        yield Digits("")
        yield Input(placeholder="Here's an input to help test")
        yield TextArea(Path(__file__).read_text(), language="python")

    def update_digits(self) -> None:
        self.query_one(Digits).update(
            ("1" if self.app_focus else "0") * (self.size.width // 3)
        )

    def on_mount(self) -> None:
        self.update_digits()

    def watch_app_focus(self) -> None:
        self.update_digits()

if __name__ == "__main__":
    AppFocusBlurApp().run()

if I focus the Input, Cmd-tab away to another window, then Cmd-tab back, I've lost my place in the form. It would be normal to expect focus to settle back where it was before once the app is focused again.

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.