tests-always-included / angular-placeholder Goto Github PK

@vitvad offered pull request #10 to improve performance in modern browsers. I've opened this issue for further discussion because I am unable to reopen the pull request.

vitvad - could you explain more about your patch and how it helps?

In IE9, on the demo page, follow these steps:

1. Click in First Name (or any of the fields)
2. Type anything (I used a space)
3. Use backspace or delete to clear out the field
4. Press TAB to exit the field
5. The placeholder text will now be the field's actual value

If you click out of the field, this doesn't happen.

.

It would be good if multiline placeholder was supported for textarea with \n or something

Great plug-in. I tried quite a few angular placeholder shims and encountered various problems with each, but yours fit my needs exactly. One request, though: the latest release in the bower registry is a bit out of date.
Could you please release the latest version? I would prefer not to reference the current version by git sha.
Regards,
---Tim---

Hello

can you publish version 1.0.3 on npm ?

I don't know what I'm doing wrong. Any helpful tips would be appreciated. This code used to reach out to Sauce Labs before and now it does not.

Any text added to the input is also treated as a placeholder (is removed when refocused).

It would be interresting that the angular modules export its name for easy use in webpack.

I would be as simple as creating a index.js file with

require('./lib/tai-placeholder');
module.exports = 'taiPlaceholder';

and use this as main in package.json

The difference is the usage of module.exports with the name of the ng module.

See for example what the angular-animate package looks like.

In 1.3 I'd expect a required error key to be set when the input initially loads, both when using required and ng-required. Only when you type in a character and remove it will the required error key be set:
http://jsfiddle.net/eL55yebe/1/

In 1.2, using required works fine, but ng-required doesn't set the required error key:
http://jsfiddle.net/at4jkx46/

Note: in all cases, removing the placeholder directive allows the required error key to be set on load.