tengqingya / p3c

Alibaba Java Coding Guidelines pmd implements and IDE plugin

2017年10月14日杭州云栖大会，Java代码规约扫描插件全球首发仪式正式启动，规范正式以插件形式公开走向业界，引领Java语言的规范之路。目前，插件已在云效公有云产品中集成，立即体验！（云效>公有云>设置->测试服务->阿里巴巴Java代码规约）。

P3C

Preface

We are pleased to present Alibaba Java Coding Guidelines, which consolidates the best programming practices over the years from Alibaba Group's technical teams. A vast number of Java programming teams impose demanding requirements on code quality across projects as we encourage reuse and better understanding of each other's programs. We have seen many programming problems in the past. For example, defective database table structures and index designs may cause software architecture flaws and performance risks. Yet as another example, confusing code structures make it difficult to maintain. Furthermore, vulnerable code without authentication is prone to hackers’ attacks. To address those kinds of problems, we developed this document for Java developers in Alibaba.

For more information please refer the Alibaba Java Coding Guidelines:

• 中文版: 阿里巴巴Java开发手册
• English Version: Alibaba Java Coding Guidelines

Introduction

The project consists of 3 parts:

• PMD implementations
• IntelliJ IDEA plugin
• Eclipse plugin

Rules

49 rules are realized based on PMD, please refer the P3C-PMD documentation for more detailed information. 4 rules implemented within IDE plugins (IDEA and Eclipse) as following:

• [Mandatory] Using a deprecated class or method is prohibited.
  Note: For example, decode(String source, String encode) should be used instead of the deprecated method decode(String encodeStr). Once an interface has been deprecated, the interface provider has the obligation to provide a new one. At the same time, client programmers have the obligation to check out what its new implementation is.

• [Mandatory] An overridden method from an interface or abstract class must be marked with @Override annotation. Counter example: For getObject() and get0bject(), the first one has a letter 'O', and the second one has a number '0'. To accurately determine whether the overriding is successful, an @Override annotation is necessary. Meanwhile, once the method signature in the abstract class is changed, the implementation class will report a compile-time error immediately.

• [Mandatory] A static field or method should be directly referred by its class name instead of its corresponding object name.

• [Mandatory] The usage of hashCode and equals should follow:

  1. Override hashCode if equals is overridden.
  2. These two methods must be overridden for Set since they are used to ensure that no duplicate object will be inserted in Set.
  3. These two methods must be overridden if self-defined object is used as the key of Map. Note: String can be used as the key of Map since these two methods have been rewritten.