teneko / teronis.dotnet Goto Github PK

The class defined in src/NetCoreApp/Identity/Identity/src/Extensions/ILoggerExtensions.cs has a namespace declared as Microsoft.Extensions.Logging. This leads to an ambiguous extension method reference and with that introduces a compile time error. The the official extension method with the same signature is defined in the same namespace.

Please consider moving the extension methods of this project into the exclusive namespace for this project so the consumers can choose what methods they want to use.

Version used: 0.1.7-alpha.17

The NuGet package "Teronis.MSBuild.Packaging.ProjectBuildInPackage" works well on adding the project references for dotnet pack, but the main issue is the unit test project which is referencing the project (i.e. the project which I am trying to package) doest recognize it has reference project when adding the attribute PrivateAssets="all". I am getting errors

"Severity Code Description Project File Line Suppression State
Error CS0234 The type or namespace name '' does not exist in the namespace '' (are you missing an assembly reference?)

Is there a way to fix this?

My project is a .net 7 android binding lib, which depends on two other binding projects (ZoomCommonLib and Lottie.Android)

I'd like to create a single nuget package without having to bother with nugets for the two dependent projects. So your project is ideal.
However the .aars are not brought over. Since XF => MAUI, .jars must now appear in the same directory as dlls, as they are no longer embedded in the .dll (source - https://learn.microsoft.com/en-us/dotnet/maui/migration/android-binding-projects)

Nuget reference setup:

  <PackageReference Include="Teronis.MSBuild.Packaging.ProjectBuildInPackage" Version="1.0.0">
    <PrivateAssets>all</PrivateAssets>
    <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
  </PackageReference>

Project reference section:

  <ItemGroup>
    <ProjectReference Include="..\Lottie.Android\Lottie.Android.csproj" PrivateAssets="all" />
    <ProjectReference Include="..\ZoomCommonLib.MAUI\ZoomCommonLib.MAUI.csproj" PrivateAssets="all" />
  </ItemGroup>

Resulting Nuget package explorer - dlls from the dependent projects are brought in correctly, but the .aars are missing

Can .aars be brought in as standard, or is there an option to include them in IncludeAssets?

Changing to

<IncludeAssets>all</IncludeAssets>

Did not change anything.

Regarding to error "error MSB3073: The command "dotnet msbuild "C:\Users\cloncar.nuget\packages\teronis.msbuild.packaging.gitversioncache\0.1.2\build\GitVersionCache.targets" -nologo -nodereuse:false "-t:GetVersionCache;GetVersionCacheInline" "-p:GitVersionCacheIdentifier="" exited with code", passing the parameter seems to override after the default value has been calculated:

https://github.com/teroneko/Teronis.DotNet/blob/fdce7daccc86722f29dda6d425db1a585a555a7e/src/MSBuild/Packaging/GitVersionCache/GitVersionCache/src/build/Teronis.MSBuild.Packaging.GitVersionCache.targets#L67

Workaround is to set <GitVersionCacheIdentifier Condition="'$(GitVersionCacheIdentifier)' == ''">$([System.Guid]::NewGuid())</GitVersionCacheIdentifier> in project where you encounter this problem.

Very cool project!!! This is incredibly handy, and should be a very popular project! Thank you for this!!

Issue

I was trying to explore the documentation, and it appears to be offline: https://teroneko.de/docs/Teronis.DotNet/Microsoft.Extensions.DependencyInjection.html

if you have some time to look into this, that would be great.
at community members like myself can contribute to the wiki documentation as well.

Suggestion:

To offload some of the maintenance of the dos and wiki to community members , which gives people like myself the ability to contribute to the wiki documentation as well, I suggest:

• Using .md files instead of a website, or use both
  • .md files are not as pretty, but much easier to expand and work with
• Use the built-in Wiki feature of GitHub

Thanks again!

Hey!

This is amazing work!
And it was working perfectly fine until I needed to add localization resources into one of the referenced projects. 🤦 😄

Please, consider that I'm referencing Teronis.MSBuild.Packaging.ProjectBuildInPackage on version 1.0.0.

Imagine this:

ProjectA
   +- Resouces
      +- Something.fr.resx
      +- Something.resx
ProjectB

When I pack ProjectB it includes ProjectA as expected (code, at least) but not its satellite assemblies.

From logs it seems to actually try to do it:

Batch for .nupkg: ReferenceCopyLocalPaths = C:\dev\sample\src\ProjectA\bin\Release\netcoreapp3.1\fr\ProjectA.resources.dll, ReferenceCopyLocalPaths.DestinationSubDirectory = fr\ Filename = ProjectA.resources Extension = .dll
C:\Program Files\dotnet\sdk\3.1.410\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5118: File 'C:\dev\sample\src\ProjectA\bin\Release\netcoreapp3.1\fr\ProjectA.resources.dll' is not added because the package already contains file 'lib\netcoreapp3.1\fr\' [C:\dev\sample\src\ProjectB\ProjectB.csproj]

The workaround so far is to force file inclusion manually:

<ItemGroup>
	<Content Include="..\ProjectA\bin\Release\netcoreapp3.1\fr\ProjectA.resources.dll">
		<Pack>true</Pack>
		<PackagePath>lib\netcoreapp3.1\fr\</PackagePath>
	</Content>
</ItemGroup>

That solves the missing reference for now but requires a constant Release build even if I attempt to build as Debug. And also has a hard reference on the file, which is harder to maintain.

Do you think it would be possible to have it also included with that same package, into a single workaround?

I am trying to use your package to include ref projects dlls to my nuget package. To build the package, the following command is executed :

dotnet pack .\$(ProjectName).csproj --include-symbols --no-build -o C:\dev\Packages

I am getting the error message :
The 'NoBuild' property was set to true but the 'Build' target was invoked.

If I remove the --no-build parameters then I don't get the error message but I'd like to keep it, otherwise the solution is rebuilt a second time as it is already built as a first step in my build pipeline.

Is this possible ?

• Allow BearerSignInManager to delete bearer tokens to reflect logout.
• Check mechanic behind SignInManager.SignIn(.., string authenticationMethod = null).

Your solution is great, but It would be even better if transitive dependencies were a thing.
I know that you aware about it, but I wonder why there's no solution for this.
Is it hard to make? I would like to make it, but I don't know much about net tools.