teleri / jammming

A react.js app where you can connect to your Spotify account though oauth, search for tracks, artists or albums, and add them to a new custom playlist, which is then saved onto your Spotify account.

jammming's Issues

Summary

Grade: Needs Improvement

I think the idea and the technical design are spot on! A couple things I would change are giving more code examples and possible screenshots to help deliver the feature request technical details. Additionally, I would redo the caveat section so it's a bit more clear as to what the drawback would be. After these changes you should have a solid Feature Request!

SUMMARY

Grade: Meets Expectations

You've done an awesome job on this project. Jammming has a ton of pieces to it, and you've incorporated everything you need. You have a great handle on React Native, how to build components, and how to pass functions between them. Your helper functions are well-implemented and your app functions well as a result.

Your code is difficult to read because of how varied the indentation and formatting is, especially your JSX. Be sure to follow HTML conventions (child elements are indented one from their parent, etc.) to clean up what you have. Be cautious of those details moving forward, as it will save time and energy for you and those you collaborate with, and because disorganized code distracts from the high quality of your React Native. I also encourage you to start commenting your code with notes that explain what each block of code does. This is an important habit in programming and definitely something you should develop as early as possible. Again, great job here and congratulations!

Feature Request - Background

I really like this idea! I think it provides a good understanding of what our users want as it's common practice to use the enter key as a sort of "submit". The HTML specification states that we should have an implicit submission as it is extremely important for assistive technologies - some impaired users cannot use a mouse at all. The enter key is an implicit submission. More info here: https://www.w3.org/TR/html5/sec-forms.html#implicit-submission

Subtle: Alignment

https://github.com/Teleri/Jammming/blob/master/src/Components/App/App.js#L23-L43

Each of these functions is aligned differently--try to choose one style and be consistent with it.

Great! Logic for helper functions

https://github.com/Teleri/Jammming/blob/master/src/Components/App/App.js#L23-L62

Awesome job tackling all of the helper functions necessary for the app.

Feature Request - Technical Design

Using built in event handlers like onKeyDown is a great idea! When that key is 'Enter', let's execute a search. I do think you could add some code examples to help increase clarity behind your idea. Example: What would our new render() look like?

Good work!

Feature Request - Caveats

I would add more detail to this caveat as to why it's a caveat for this particular feature. An example of this might be "The user hits enter by accident before they finish typing" - and then follow up with a potential solution to this drawback.

Important: Commenting

In a multi-page app like this one, commenting is critical. Leave comments before each function and major block of code indicating its purpose.