telemetrydeck / telemetryviewer Goto Github PK

The save new insight modal doesn‘t dismiss when tapping ”Save”, but the insight is saved (invisibly the background). Close button doesn‘t work, either.

I‘d like to be able to see how many signals were received per user, on average. So if I get 10 signals from user A and 20 signals from user B, I‘d want an insight to show me that on average, 15 signals were received per user. This should work with signal type and filters, and would be very powerful.

It'll be nice if the hover additional info is displayed for the buttons in the toolbar, I'm not familiarized yet with the buttons, and I expected to see helpful info after hovering over it like in other apps

Der TelemetryViewer crasht übrigens immer wenn ich was ins Insight Name Feld tippen will. Hab dir via TestFlight die Logs geschickt.

When I tap the eye button and then the edit button, in the pop up form the Group is always Signals (the first one).

When I look at a line chart, I don't know what the lowest and highest numbers are.

Please add low/high number markings.

• Daniel: #68
• Read into how widgets work
• Display a very simple example widget, like just a Text("🥕🥦🍅")
• Vend widgets for each insight ID in widget list
• In the widget, download the insight calculation result and display, e.g. the title
• Update widget code to actually render the widget as graph
• Add UI to add/remove from widget list in EditorView
• Make Placeholder Widget say something like "please choose an insight in this widget's options"
• Add the App name to the insights in the widget options either as sections or in front of the insight name. Otherwise it's really confusing.
• Change the widget api thingy to give a dictionary of apps:widgetable insights @winsmith
• make the search work in widget options
• @winsmith: Remove widgetable properties from DTOv2.Insights
• Show App Name in Widget Title
• Design: Font size, y-axis, etc. Make it look nice (but don't spend a huge amount of time on that)
• Show last 30 days of data
• Opening the app should reload widgets data
• @winsmith Blog Post
• raw charts
• reduce title text size for small widgets
• intent for number of days shown.

Nice articles

• https://useyourloaf.com/blog/widgetkit-for-ios-getting-started/
• https://swiftwithmajid.com/2020/09/09/building-widgets-in-swiftui/
• https://developer.apple.com/videos/play/wwdc2020/10194/ 11:24 explains sections
• For Deeplinking, https://betterprogramming.pub/deep-links-universal-links-and-the-swiftui-app-life-cycle-e98e38bcef6e explains it nicely, but it seems to be more work than I initially thought, so maybe that's its own feature.

Show these on launch and, eventually, in widgets

• Model: Mark Insight as Expanded / Not Expanded
• Client: Expand Insights so that they use up more space

When I let my laptop sleep, the next day, when I try to open up Telemetry, it's unresponsive (sometimes I check skipping one day though)

There should be some kind of autocomplete for the insight conditions and payload key fields. Maybe it's possible to show suggestions in the system autocomplete bar, or maybe it's better to disable that and show it in a different way. (Keyboard accessory view, dropdown…)

When testing build 5 on my iPod Touch (4“ screen), I noticed that the top buttons can‘t be interacted with because they are too small. The only one that registers the touch is the (currently disfunctional) Settings button.

This just makes for dumb telemetry, which is kinda unfortunate in the case of this app

Edit modal for the insight doesn't show the latest configuration after saving it (it does show in the graph, but not in the modal)

Steps to reproduce:
1.- Edit an insight (e.g. add a key for breakdown)
2.- Save (see visual changes)
3.- Edit the same insight, it'll have the old info instead of the new one you just saved

This can be worked around by exiting the insight group page and opening it back up, then the edit modal will have the proper info displayed

Edit

• Name
• Order
• Group

Show Read-Only

• Type
• Time Frame
• Conditions
• Payload Key

• Server: Allow Insights to be marked as favourites
• Server: Get list of favourite insights
• Client: Show Favourite insights on front screen

When adding an insight I get an EXC_BAD_ACCESS crash.

There are several of these in the console:

[SwiftUI] Publishing changes from background threads is not allowed; make sure to publish values from the main thread (via operators like receive(on:)) on model updates.

These are blamed on APIRepresenative.create(insightWith: …) line 298: self.getInsightGroups(for: app), more specifically APIRepresentative line 364. Moving the .receive(on: DispatchQueue.main) to the top (line 357) did not fix it.

The next time I launch the app, the signals appear in the list, so no data is lost.

• Fix a display bug in iOS Insight Editor
• Reload Insight Groups on save

Currently the full User ID is shown in the Raw Signals screen. It isn‘t very useful to see that because it‘s a random ID and also included in the signal body. So I suggest either hiding or shortening it to make the list more readable.

While creating a new insight or editing an existing one, would it be possible to show a preview of the insight at the bottom of the screen? That would be very useful feedback to the user about the parameters they've set.

• Show Current Value
• Add X Values
• Add Y Values
• Dashed line to current value

I believe this is directly related to #37 – swiping down the sheet doesn't change the isPresented value to false, therefore tapping the button won't do anything anymore.

Telemetry Viewer[1086:22441] Fatal error: No ObservableObject of type APIRepresentative found. A View.environmentObject(_:) for APIRepresentative may be missing as an ancestor of this view.: file SwiftUI, line 0

HSplitView, etc etc

When I tap Save after filling out the form to create a new insight, the sheet remains on screen as if the button didn't register. However, the new insight is saved correctly.