tehuti-io / tehuti Goto Github PK

Make the methods in MetricsRepository (MetricsRepository#sensor() and MetricsRepository#addMetric()) consistent.

Right now, Repository name, Sensor name, and Metric name are orthogonal. It makes more sense if prefixing the former in front of the latter and separating them by dot. That being said, if repository A has a sensor called B which contains metric C, the full name of this metric would be A.B.C.

Since JMX has the similar naming convention, this also makes it easier mapping metrics into corresponding JMX attribute.

Reporter right now registers stats at metric-level. If the metric belongs to a existing sensor, it unregisters the sensor first, and then re-registers the whole again. It is overhead. Reporter would better have a method for sensor-level registration.

Tehuti MetricsReporter used to not have feature that unregisters metrics so that MetricChange was only in charge of adding new metrics. This method's name becomes vague since we are introducing the unregister feature.

It is reasonable (and useful) to let the Metric be able to reset Stats corresponding to it. Right now, only Stats is able to reset values by it own.

It might be better to move JmxReporter#prefix to MetricsReporter and add a compareTo method in MetricsReporter that returns true if (this.getClass == a.getClass) && this.prefix == a.prefix).

In that way, we could check if there is existing reporter before adding new reporter in MetricsRepository.