teemip / teemip-cable-mgmt Goto Github PK

I notice that this extension, which seems highly useful, is not available to install through the iTop Hub. I can install it by hand, of course, but I really prefer not to mix manual and Hub-installed extensions on the same instance.
Any chance of getting this packaged up and deployable through the Hub?

Hi Christophe,

First of all, thanks for this great extension and for making a bridge module to Datacenter View Extended! 🙌

Symptom

I've got feedback from some users of both extensions reporting that PatchPanel objects were not displayed in Racks/Enclosures graphical view by default.

Cause

Although the necessary DM attributes and methods are presents on the PatchPanel class, it is not enabled in the custom_device_classes module parameter (see here)

Workaround

They can add the class to the module parameter manually.

Example

'molkobain-datacenter-view-extended' => array (
    'custom_device_classes' => ['PatchPanel'],
),

Solution

I was about to make a PR for this, but then the way to actually do it wasn't that obvious and I would like to know how you would prefer it to be done.

Option 1

Convert module parameters of DVE to XML module parameters

Pros

• You could add PatchPanel as an XML delta.

Cons

• Doesn't seem like a good idea as the param. is already written in the conf. file of all users.
• Would not work for any user who already overloaded the param. in their conf. file.

Option 2

Use the \ModuleInstallerAPI::BeforeWritingConfig(Config $oConfiguration) API to add the value to the existing values.

Pros

• Would work for everybody, including those using existing version of DVE

Cons

• We don't have the version numbers of the module being installed, therefore we can't alter the parameter only once, it will be done at each setup, which can be an issue (?) or at least isn't very clean. But, it is done by Combdo here 😁

Option 3

Use the \ModuleInstallerAPI::BeforeDatabaseCreation(Config $oConfiguration, $sPreviousVersion, $sCurrentVersion) API to add the value to the existing values.

Pros

• Would work for everybody, including those using existing version of DVE
• Could be done only once when installing the new module version

Cons

• That API is not made for this, not sure it would work in the future. Plus, it never feels good to "hack" an API for something out of its scope.

Questions

• Which option suits you the best? Or do you have a better option?
• Would you consider a PR for this?

Take care,
Guillaume

I love the extension and appreciate all the hard work into developing it. I am currently limited with the ability to track and view relations of connections from physical interfaces to other physical interfaces.

For example, I have managed switches that connect directly to endpoints or servers with Ethernet cables and would love to be able to see these assets when viewing the "Wiring" relations.

I have set the Physical Interface wiring properties on both sides to document the connection, but this does not populate in the relations view.

Server X Physical Interface Port 0
Network socket: <blank>
Remote device: Office Access Switch
Remote physical interface: Office Access Switch GigabitEthernet0/9

Office Access Switch Physical Interface GigabitEthernet0/9
Network socket: <blank>
Remote device: Server X
Remote physical interface: Server X Port 0

It is actually not possible to connect a network device directly to another network device with a patch cable.