teelolws / editmodeexpanded Goto Github PK

On Retail, using the latest version of EME, upon logging in:

4x ...d/libs/EditModeExpanded-1.0-24/EditModeExpanded-1.0.lua:562: attempt to index field 'settings' (a nil value)
[string "@EditModeExpanded/libs/EditModeExpanded-1.0-24/EditModeExpanded-1.0.lua"]:562: in function `func'
[string "@EditModeExpanded/libs/EditModeExpanded-1.0-24/EditModeExpanded-1.0.lua"]:1032: in function <...d/libs/EditModeExpanded-1.0/EditModeExpanded-1.0.lua:942>

Locals:
db =

When you move for example the Soul Shard frame around and close the edit mode it will be slighly lower positioned. This is a problem when you want to positon the frames really close next to erach other since they maybe overlapping afterwards.

Hi, thanks for this addon but i have a request, i'd love to be able to move this frame:
CompactRaidFrameManager

https://imgur.com/K2jlRkL

Thanks in advance

I don't know if this is a usage issue or a bug but when I uncheck the Backpack frame when in edit mode, it disappears while I'm in edit mode but when I leave edit mode it comes back. I expected it to be hidden outside of edit mode as well.

I have tried everything but the pet frame is missing if your addon is on. The moment i disable your addon it shows again. And yes i have tested with only your addon enabled and no other addons.

It only doesn't show up when this addon is enabled, I checked the edit mode settings and none of them have this as an interactable option so maybe that's why it isn't showing up? Not sure.

Something in todays patch broke it, booo.

When you install the new update "EditModeExpanded-10.0-020.zip" addon dont work. I tried to reinstall it and nothing, try to install previous version and work but when you update stop working. Probably the new update has some problem when you install it

Target cast bar by default is below target's buffs+debuffs, however, sometimes when in combat, the target cast bar appears to overlap with the target's buff instead, causing it to be difficult to see the cast bar as it is below the buffs. I attached an image for your convenience, hope it helps.

Checking another addon like MoveAny:

https://www.curseforge.com/wow/addons/moveany

I have a few suggestion to add more UI elements like Target of target, castbar from target of target and castbar from Focus. Also Alert frames like the achievements or the battle.net online/offline friends and the durability doll.

Thanks.

Once I figure out how to display a custom Settings box, I'll add an option to simply hide the selected frame. Maybe the player doesn't want the stock Menu Bar showing?

Support is going up soon.

Has some issues and needs further testing.

To move the minimap icon, you have to:

1. Shrink the size of the LFG Frame to be smaller than the Icon texture behind it
2. Exit Edit mode
3. Be in the queue for something, so the icon is visible outside of Edit Mode
4. Drag the Icon texture around / behind the LFG button. The button will follow the Icon around
5. Once you have the LFG Button where you want it, you can go back into Edit Mode and make the LFG Button bigger again

The Dragonriding Power Bar (the bit with your orbs meter) is covered under the base UI "Encounter Bar".

I did not notice it was already implemented, and should not have added support.

Hey,

i really like to be able to move more frames around since i like a clean UI.

I usually have my actionbars really close to the player and target frame. This makes problems with the PetFrame (which is already solved by the addon) and with the TargetOfTargetFrame (i belive it's called TargetFrameToT in the frame stack).

Would be cool if you could add the TargetOfTargetFrame to the movable frames.

Cheers

Probably related to #41, would be nice if you could hide the stance bar.

Thank you for making this great addon. Could you please add support for moving resource bar of other classes like Death Knight's runes and Mage's arcane charge.

If i decide to not use one of the frames they seem to position somewhat hardcoded. If e.g. Soul Shard is disabled they will always be in the bottom left corner. I haven't found a way to get them back to the player frame except disabling the addon.

Planned, if its possible without causing problematic taint.

I'd like to make the Micro Menu and Backpack bars separate groups that can be moved around independently.

In the settings for all other Action Bars you can choose the Visability Option between:

• always visable
• in combat
• out of combat
• hidden

It would be nice if we could apply these to Action Bar 1 as well.

I use Bartender 4 to move the LFG & Experience Bars. EME activates move mode on all the Bartender objects, but EME was adding it's own LFG & XP bar objects as well as unlocking the B4 ones so they could be repositioned. Not positioning them together results in a random precedent for where the bars end up. I ended up having to uncheck those options in the EME settings window, and just positioning with the B4 objects. I'm not sure if this is intended behavior that just isn't explicitly stated in the addon description, an EME problem or a Bartender4 one.

Structure I plan to try, when I have time to code it up:

Catalogue a list of frames that are already edit mode supported.

In functions like Register Hideable, Register Resizable, etc, check if it is a preexisting frame. First time registering one, store it in a separate DB.

When one is selected, open the EME dialog box next to the existing dialog box. Do not try to interfere with the existing dialog box.

Put the calls to Register Hideable, etc, in the main addon lua, not in the library.

When positioning the target castbar frame while in edit mode to e.g. line it up with the grid it works fine. Once you cast something it seems of. Maybe because of the icons or the header bar for the castbar.

Hi there. Is the Achievement option missing for others, or is it just my end? Oh, and also totem seems to be gone too.

Heya, i love how i can fine tune the frames affected by this addon with the arrow keys, do you think you can expand that to all frames? Or it might cause issues?

Looking to replace Bartender4 with this mod and the new default UI. However, a few adjustments I would need to do this:

1. Ability to set gap spacing to 0 instead of lowest being 2. Bartender lets you do 0, I believe it even lets you go into the negatives (which I don't need). For skills on action bars as well as for the bags spacing on the bag bar.

2. Old UI let you resize how far to the right vertical raid groups could draw, so you could limit to at most 4 per row, as little as 2 per row. for 2 rows of 4 vertical groups or 4 rows of 2 vertical groups. New UI only lets you do 1 row of 8 groups. Being able to adjust this again like old UI would be awesome. My specific request is to get 2 rows of 4 vertical groups again, though more flexibility would be helpful for more users.

6x [ADDON_ACTION_BLOCKED] AddOn 'EditModeExpanded' tried to call the protected function 'PetFrame:SetPoint()'.
[string "@Interface/AddOns/!BugGrabber/BugGrabber.lua"]:480: in function <Interface/AddOns/!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function SetPoint' [string "@Interface/AddOns/EditModeExpanded/libs/EditModeExpanded-1.0-16/EditModeExpanded-1.0.lua"]:359: in function RegisterFrame'
[string "@Interface/AddOns/EditModeExpanded/EditModeExpanded.lua"]:133: in function <...terface/AddOns/EditModeExpanded/EditModeExpanded.lua:40>

Hiding the Soul Shards isnt working as they re appear after a reload of ui

Hi,
Something that could be really nice to add to move is the yellow information that appear in top of the screen like pvp flag information, or what we could see during some dungeon (like cavern of time that tell us portals).

I hope it's possible and you could add it in a future patch <3

    What about an option that hides the frame but show it once you hover over it? Similar to the way Bartender do it?

Originally posted by @Nillx in #5 (comment)

Update: Won't be implemented. See other comments for alternatives!

Easy reproduce (for me):

• Logging in
• Take myself into target
• Cast some mount
• The target cast bar sometimes jumps instantly to the desired position and sometimes on cast finish/interrupt

It seems I get the same behavior when changing targets.

@cdeconinck since you wrote the UI Resize scaling code, I'm hoping you can help with this issue #22

If a frame is placed on the right hand side, like this:

Then the window is resized smaller, it scrolls off the edge of the window

Eventually being hidden

I'm thinking something like... when a window resize event is detected (is there one?), check if the right side of the frame has gone out of bounds and adjust the bottom left anchor?

Just tried EditModeExpanded and disabled the addon to check something. Reloading UI threw this error:

2x bad argument #1 to '?' (Usage: local accountInfo = C_BattleNet.GetAccountInfoByGUID(guid))
[string "=[C]"]: in function `GetAccountInfoByGUID'
[string "@FrameXML/SocialQueue.lua"]:171: in function `SocialQueueUtil_GetRelationshipInfo'
[string "@FrameXML/SocialQueue.lua"]:236: in function `SocialQueueUtil_HasRelationshipWithLeader'
[string "@FrameXML/QuickJoin.lua"]:408: in function `UpdateLeader'
[string "@FrameXML/QuickJoin.lua"]:391: in function `Update'
[string "@FrameXML/QuickJoin.lua"]:362: in function `UpdateAll'
[string "@FrameXML/QuickJoin.lua"]:352: in function `Init'
[string "@FrameXML/QuickJoin.lua"]:320: in function `UpdateAll'
[string "@FrameXML/QuickJoin.lua"]:42: in function <FrameXML/QuickJoin.lua:40>
[string "=[C]"]: in function `Show'
[string "@FrameXML/FriendsFrame.lua"]:77: in function `FriendsFrame_ShowSubFrame'
[string "@FrameXML/FriendsFrame.lua"]:396: in function `FriendsFrame_Update'
[string "@FrameXML/FriendsFrame.lua"]:345: in function `FriendsFrame_OnShow'
[string "@FrameXML/FriendsFrame.lua"]:465: in function <FrameXML/FriendsFrame.lua:463>

Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local accountInfo = C_BattleNet.GetAccountInfoByGUID(guid))"

If I open the friends list and go to the Quick Join tab while no one is active it throws the same error. While people are active (ie: there are groups I can quick join) that tab doesn't throw the error. Never seen this error before today, and it's only started since installing, and then disabling EditModeExpanded.

Exited WOW completely and restarted and it doesn't seem to be throwing the error now.

I'll probably do this with a simple copy/paste system.

I know this can be moved with the standard edit mode but for whatever reason, Blizzard hasn't allowed it to be resizable. I know it's possible as there is a WeakAura that can do it, however, I don't really want to install a large addon like WA just for this one thing.

Thanks for your work!

Look into adding support for moving it.

Trying to find an actual cause for this. I suspect its something to do with the splash screen that shows first login per patch.

I've attempted to include this frame, but unfortunately it seems Blizzard has code that moves it back to just under the Target Frame again. The position is based on how many buffs your target has, and is constantly being updated. This means moving the Target's Cast Bar is not simple, and may not even be possible.

When I use this addon, it seems that the achievement frame is right of center. When I use it in the default layout, achievements, loot, etc show perfectly in the center. However, when I adjust the achievement frame with the addon, I notice that when I get an achievement, loot, etc is left of center.

It seems that the movement of the frame works fine and the achievements, loot, etc appear fine until I do a /reloadui or logout and log back in. The achievement frame will stay where I move it, however, when an achievement or loot shows up then it is left of center.

Using the reset button, puts it back right of center but then achievements and loot appear centered. I hope my screenshots explain better than how I tried to explain this.

Planned feature: will base frame's positions based on the settings saved per Edit Mode profile.

It currently just uses a simple saved variable per character.

I didnt notice https://github.com/teelolws/SLMicroMenu is an addon from you and this one is amazing also. Do you have planned merge both addons in 1 adding SLMicroMenu as an EditModeExpanded option??

I think this is a good idea and we can save 1 addon.

Will need to find a way to create an EditModeDialog that doesn't interfere with the base Edit Mode. Will just have a Slider to resize the selected frame.

Will need to unlink it from the Micro Menu Bar. Is planned to be worked on.

Would be great if we could the bar separate from the normal UI.

Should only set scale for frames that have scaling enabled.

Check db.settings exists.

Do something about the anchor connection error for the vehicle frame.

Possible to fixe this? I can't them even move.

I get weird interaction with addon "Minimap Button Bag Reborn" when LFG-eye checked "pin to minimap"

MBBR trying to hide LFG-eye into folder. After moving LFG-eye, its place resetting to hide in folder again

Can you fix this?

Can be tested on Affliction Warlock with Summon Darkglare talented.

The position of the class resource (can be tested with other classes than warlock aswell e.g. mage with Rune of Power)

When the event PLAYER_TOTEM_UPDATE is triggered it causes a repositioning of the TotemFrame + PlayerFrameBottomManagedFramesContainer which causes the resources to be place below the PlayerFrame again.