techspaceco / brivo Goto Github PK

On the above and similar usage of Net::HTTP, we need to have a fairly aggressive timeout set - the default read_timeout and open_timeout are 60 seconds. Should also set ssl_timeout in case the handshake takes a long time.

With any third-party API wrapper, some documentation in YARD would go a long way.

If we release this to the world, we should probably have it adhere to popular conventions. We can turn the stuff off we don't like (to keep seattle.rb style).

Like any API wrapper, there is a fair bit of string munging. Where possible, strings should be frozen with magic comments, or String#freeze (and potentially any object that you don't want to be able to be mutated, like a Brivo::Application instance).