The checkers from tcbegley

checkers's People

Contributors

Stargazers

Watchers

checkers's Issues

Player ID display gets out of sync when stepping back/forward

The backend uses Player ID's 1/2, while the frontend seem to expect 0/1 in the logic of stepping forward and back, like:

checkers/frontend/src/stores.js

Line 45 in 0df2d8b

player: 1 - player,

Thus after stepping backwards/forwards, can end up with players -1/2 or players 0/1 in the display. I guess the correct logic is player = 3 - player but it's a bit cryptic that way, and other parts might also be affected by the mismatch.

Running dev fails

Running docker-compose -f docker-compose.yml -f docker-compose.dev.yml up --build as mentioned in the docs fails with:

frontend_1  |
frontend_1  | > [email protected] start /checkers/frontend
frontend_1  | > webpack-dev-server
frontend_1  |
frontend_1  | sh: webpack-dev-server: not found
frontend_1  | npm ERR! code ELIFECYCLE
frontend_1  | npm ERR! syscall spawn
frontend_1  | npm ERR! file sh
frontend_1  | npm ERR! errno ENOENT
frontend_1  | npm ERR! [email protected] start: `webpack-dev-server`
frontend_1  | npm ERR! spawn ENOENT
frontend_1  | npm ERR!
frontend_1  | npm ERR! Failed at the [email protected] start script.
frontend_1  | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
frontend_1  | npm WARN Local package.json exists, but node_modules missing, did you mean to install?

Recommend Projects