tcaiazzi / kathara-lab-checker Goto Github PK

The current behavior of the software is that if there is a folder non containing a lab.conf it crashes stopping all the process.
This is an unwanted behavior since the next start will be from scratch. If I'm passing over many directories, it will take a lot of time to process them from the beginning.

I see here two possible solutions if there is no lab.conf:

• Just skip the directory, catch the exception, write something in stdout, and pass over.
• Let the software crash, but implement a --resume option that avoid testing a directory if inside that directory there is already a test_results directory

The current configuration takes in input the path of a folder called structure.
The software then reads automatically the lab.conf file inside that folder to understand the correct device links.

It is unclear to me why in the configuration is not directly specified the lab.conf file path, so that the file could be called in a different way.
Imagine if you have multiple configuration files each of it with a different lab.conf. It would be great to use a single folder containing all the structure files named in different way and many configuration files that points to different .conf structure files.

The configuration json should allow to specify which daemons are not allowed to run on certain devices.

IMHO, the "daemons" section of the file should be transposed with the device name as key and the list of the running daemons as value, in this way, if on the device there is a daemon that is running but not listed, the system should give a proper warning.

Hint: the jc library can parse a systemctl output ;)

The print of the commands output should be moved from the library file to the main file, according to the returned type.
This change allows to threat the library as a real library that do not need interfacing with the console or the stdout of the process.

Once this modification is completed, there should be CLI parameters to specify different output verbosity (-v, -vv, -vvv) for the stdout. The first should just output the summary of each folder (student). The second should output just the test that do not pass, while the third should give the same output as now, writing all the test sequence.