tblong / aws-snapshot-tool Goto Github PK

Need to fix set_resource_tags(resource, tags) to properly check args

snapshot name is not checked

Currently the only tag being searched for is tag_name. This poses a problem if a backup script will be running on two separate EC2 instances across two separate customers. Once the same script is installed on another customer's set of instances, the second backup script will invoke a snapshot of the first customer's instances since the same key-value pair criteria is used. Add flexibility to the config.sample and makesnapshots.py files where both a customer=name and autosnap=true key-value pairs must match before a snapshot is both taken and removed.

https://docs.python.org/2/howto/doanddont.html#from-module-import-name1-name2

The config file's config dictionary is currently being imported directly into makesnapshots.py. Improve the import per the above link.

The format should match the start time format %Y-%m-%d %H:%M:%S