taurusgroup / frost-ed25519 Goto Github PK

Right now, it seems FromBytes functions assume the byte slices in arguments have correct lengths -- if not, they'll panic.
This assumption should ideally be documented or more explicitly handled (e.g. by returning a nil or an error instead of a panic).

An example panic:

panic: runtime error: index out of range [1] with length 1

goroutine 9 [running]:
encoding/binary.bigEndian.Uint16(...)
        /usr/local/go/src/encoding/binary/binary.go:101
github.com/taurusgroup/frost-ed25519/pkg/frost/party.FromBytes(...)

Hey there,
When you init a "NewKeygenState" with "frost.NewKeygenState", you are getting the following error:

`panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x8 pc=0xfd8621]

goroutine 169 [running]:
github.com/taurusgroup/frost-ed25519/pkg/internal/polynomial.(*Polynomial).Reset(0x0)
C:/Users/brend/Go/pkg/mod/github.com/taurusgroup/[email protected]/pkg/internal/polynomial/polynomial.go:73 +0x21
github.com/taurusgroup/frost-ed25519/pkg/frost/keygen.(*round0).Reset(0xc001086000)`

The Error is present for me under all circumstances