tarwin / poko Goto Github PK

Hi, I wanted to compile the CMS with haXe, and I found some
lowercase-uppercase issues:
 - in site.cms.modules.base.DatasetItem.hx there's an import line:
   "import site.cms.modules.base.formElements.KeyValueInput;" but the
FormElements folder is uppercased.
 - in src/Main.hx there's an import line:
   "import site.examples.ImportAll;
" but the importAll.hx is lowercased.

If these are fixed, it compiles fine.

select opening tag is self-closing which can produce bad parsing

The poko framework and cms is great, but the 0.51 version needs some
reconstruction and the MakeTemplates.hx needs some tweaks. I will attach my
version of the lib, but I will write down all the changes which should be
addressed in the next release.

The src folder should be eliminated and both poko and site sources should
be moved to the lib root in order to be accessible through a simple -lib
poko switch, people shouldn't have to copy the sources in the project
directories. The makeTemplates sources folder could be moved to a tools
folder and the design folder should go into the www/_src_ folder. All the
compile code should go into the www/_src_ folder too. With these changes
you can achieve that the user should only copy the www folder to his/her
project folder, launch the compile code there, and all the code will
compile into that directory.

MakeTemplates.hx is Windows only in the 0.51 release! Instead of calling
the temploc2.exe file, you should call neko and the temploc2.n file inside
the haxelib folder. That eliminates the OS dependant binaries. The filepath
strings should be processed with care too, because the Windows backslashes
throw errors in Linux (and probably in MacOSX too). And because the layout
of the poko lib is changed and the site sources and templates are kept in
the haxelib directory, you should introduce a new attribute in
MakeTemplates.n which we can use if we want to compile the core mtt files.
I called this attribute -includecms. If includecms is set, we get the
recurse function to crawl through the site directory in the poko lib
directory. To make this successful, the MakeTemplates.hx was radically
changed, the recurse function takes two arguments: one basepath argument,
and one optional path argument. The items get into the items array relative
to the basepath, so the cleanUp function is obsolate.

Another small changes are the removed .bat files, which again are Windows
things, everyone can make a Linux alternative of course, but you too could
use Ant or Makefiles which are OS independent. It's cool that you included
the fla source of the logo, but a more opensource fileformat would be cool,
I made an svg file with inkscape. Your logo uses an Adobe font, which you
probably want to change because of licensing issues, I used the Soul Papa
font which is free and somewhat resembles your choice.

If the things above are badly explained please have a look at my version of
the plugin (successfully tested on WinXP and Debian Lenny). It would be
great if you would address the haxelib usability and cross operating system
issues in the next release!