tardog / schutzstreifen Goto Github PK

Currently, every user has access to everything, including the CRUD for models such as HazardType or User, which should not be manageable by regular users.

The goal is to have a dedicated admin user account for this kind of higher access level. Everyone else should just be able to register, add new hazards, and edit their own hazard entries.

Validation needs to be concise, clear, and prevent unexpected or malicious input whenever possible. Types are enforced during request model binding - maybe validation should happen before that to prevent the application from running into an error.

In addition, the errors should to be presented nicely on the frontend.

There is still debug output (stack traces) happening on several occasions. That kind of sensitive information should be logged somewhere, but not exposed to the user by the frontend.

During experimenting and learning the Gobuffalo framework, a lot of duplicate boilerplate code has been introduced, along with a huge amount of single-line comments explaining what the code does (as if that wasn't obvious).

The comments should be cleaned up, and code duplication should be reduced where it seems sensible to do so.

The app needs better test coverage. Every important route should at least be covered by integration tests (using a test database), including happy cases and error cases.

Since there is very little business logic - as opposed to framework code - testing isolated units should be considered only when integration testing doesn't cover everything.

First things first: I love the idea of the project!
Another thing: is there an instance running somewhere? Or is it supposed to be running for each campaign on its own? Please expand the question as you see fit to elaborate :)