Coder Social home page Coder Social logo

Comments (4)

Tape-Worm avatar Tape-Worm commented on May 31, 2024

Yep. That sure would create an event leak.

It should be easy enough to fix by unassigning the event in the Dispose method or using a WeakEventManager to bind the event.

Unfortunately, I don't have a lot of time these days to look into this, but if you're willing to make a PR for it, I can merge it. Otherwise it'll likely have to wait for a bit until I have the time to dig into it.

from gorgon.

AMartyn avatar AMartyn commented on May 31, 2024

PR is ready: #4

from gorgon.

Tape-Worm avatar Tape-Worm commented on May 31, 2024

So, I'm a complete dumbass. I told you to use Dispose and I really shouldn't have, and you, being the nice person you are made me a PR, which, unfortunately I couldn't use. So sorry about that.

I did however make the time to fix the bug, and a new release (2.0.1) is now up. Again, I apologize, I should have been more careful.

I've also included a test repo project for this bug in the solution to ensure that the issue is solved.

from gorgon.

AMartyn avatar AMartyn commented on May 31, 2024

Wow, you're cool. I've barely found time to make a straightforward modification in a couple of files, while you've managed to do it in a proper way all around! That's a great job, thank you a lot!

from gorgon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.