Comments (4)
Yep. That sure would create an event leak.
It should be easy enough to fix by unassigning the event in the Dispose method or using a WeakEventManager to bind the event.
Unfortunately, I don't have a lot of time these days to look into this, but if you're willing to make a PR for it, I can merge it. Otherwise it'll likely have to wait for a bit until I have the time to dig into it.
from gorgon.
PR is ready: #4
from gorgon.
So, I'm a complete dumbass. I told you to use Dispose and I really shouldn't have, and you, being the nice person you are made me a PR, which, unfortunately I couldn't use. So sorry about that.
I did however make the time to fix the bug, and a new release (2.0.1) is now up. Again, I apologize, I should have been more careful.
I've also included a test repo project for this bug in the solution to ensure that the issue is solved.
from gorgon.
Wow, you're cool. I've barely found time to make a straightforward modification in a couple of files, while you've managed to do it in a proper way all around! That's a great job, thank you a lot!
from gorgon.
Related Issues (20)
- Port to .NET 5 HOT 4
- OnAssignDirtyItem(int, GorgonStreamOutBinding)': no suitable method found to override HOT 2
- Change editor file system UI
- Editor plug in system is under documented, and kind of a mess.
- Error when calling GorgonGraphics.EnumerateAdapters HOT 4
- Question HOT 5
- Overload LoadTrueTypeFontFamily HOT 6
- Error starting any of the examples HOT 4
- Question regarding Direct3D 11.4 HOT 6
- Add a means in the editor exclude folders from packed files. HOT 1
- Add GUI controls to graphics library HOT 1
- Go back through the animation builder object and document it to make reference to the track registration system.
- Add editor API usage example
- Add an example for particle system. HOT 1
- Add examples for editor plug in creation.
- Add font editor to Editor HOT 1
- Add another tool to the editor that allows us to pack multiple images into a texture atlas.
- Can not register a device (mouse/keyboard) when my project is build in x64 mode HOT 6
- Can not override WndProc function HOT 1
- Noesis Gui integration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gorgon.