Coder Social home page Coder Social logo

Comments (4)

kurtkopchik avatar kurtkopchik commented on June 23, 2024

The plugin was created before dockerComposeDown existed which is why I'm using dockerComposeStop instead. A lot of people are on older versions of Docker (especially build machines) so I would prefer to introduce dockerComposeDown in a minor version as you suggest and deprecate dockerComposeStop for eventual removal in a future major version release.

One thing I did like about dockerComposeStop is that you do have the ability to leave your containers behind which can be helpful when debugging an instance that fails to start.

As for the particular issue with named volumes it would also probably be pretty easy to add some code that gets the set of named volumes and explicitly removes them using docker volume rm <volumeName> command in the same fashion that I remove named networks during the execution of the dockerComposeStop.

from sbt-docker-compose.

kurtkopchik avatar kurtkopchik commented on June 23, 2024

Hi @ches, so that you are not affected by the current dockerComposeStop command leaving behind named volumes I made an update that attempts to remove them on shutdown in a similar fashion to how named networks are removed.

I haven't extensively tested it but released a 1.0.24-SNAPSHOT version for now. If it works for you I can look to get it included in the next official release.

resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/"
addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.24-SNAPSHOT")

from sbt-docker-compose.

ches avatar ches commented on June 23, 2024

Thanks a lot for doing this @kurtkopchik, I could have taken a stab at it but you beat me to it. Just getting back to it after a few days but I'm using the snapshot now and it's working well so far.

from sbt-docker-compose.

kurtkopchik avatar kurtkopchik commented on June 23, 2024

Hi @ches - Happy to help! This change is now included in an official release:

addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.24")

from sbt-docker-compose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.