Comments (2)
Hi @ches, thanks for the feedback and evaluating the plugin!
I agree, that adding the custom tags to a label
instead of as part of the image
value would make the compose file more portable for direct use by docker-compose
. I certainly would be open to a PR that adds the ability to be able to define custom tags within a label
.
Note that the custom tags mostly play a part in relating your docker-compose
definition to a multi-project
sbt build. If you are just using a more basic sbt
project you should not need to use custom tags at all and the docker-compose
file should be directly usable with docker-compose
.
from sbt-docker-compose.
Thank you for your prompt reply Kurt.
I think the plugin is 90+% of the way to serving my use case, I have a few questions about how things are intended to work that I'll ask through another issue to keep discussion here on the original topic (or if there's a Gitter or something that you'd prefer as a channel for questions, let me know).
There are some situations where the functionality currently provided by custom tags might be useful outside of multi-project builds, for instance I might already have the tagged image versions that I need pulled to my laptop and when I'm getting on a plane I want sbt-docker-compose to stop trying to hit the network to pull those images only to find the tag versions are still up-to-date locally. From what I can tell <skipPull>
is a way to achieve that, even if it wasn't the intended use of it (?). There may be other ways to solve this, I'd probably prefer that such network pull
s are avoided by default if a specific image tag is already available locally—as docker-compose
seems to work—with an "always pull" option being the opt-in special case instead of "skip pull".
But regardless, multi-project use cases or not doesn't change whether labels might be a workable way to steer plugin behavior more portably. I think it's worth taking a stab at it.
from sbt-docker-compose.
Related Issues (20)
- Plugin starts tests even if not all containers are ready. HOT 4
- useStaticPorts does not seems to take effect HOT 2
- -debug doesn't work with specs2 HOT 2
- How to link my scala app's container, created by sbt-native-packager, to the dependency containers? HOT 1
- dockerComposeTest does not remove Docker instances when the compliation fails HOT 7
- multi project build with sbt-native-packager HOT 2
- DockerComposeTest does not pick up FeatureSpecs HOT 3
- Specs2 tests that have a different constructor don't run
- dockerComposeTest returns success on compilation error
- Provide dockerComposeTestOnly HOT 1
- Question - where does sbt-docker-compose plugin live? HOT 2
- Exception for invalid volume definition
- Configurable 'instanceName' (-p project-name)
- Forthcoming Deprecation / Transfer of Ownership Notice HOT 2
- SBT 1.3.3 breaks sbt-docker-compose
- dockerComposeTest doesn't include parent test scope in dependency classpath
- "Could not parse image id" HOT 1
- Support docker-compose 2.x HOT 3
- Run specs2 tests in multi-project code? HOT 4
- SBT 1.1.0-M1 compatibility issues HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-docker-compose.